Bug 191239 - Cache glyph paths and share underline skipping code between all the ports
Summary: Cache glyph paths and share underline skipping code between all the ports
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks: 190774 191630
  Show dependency tree / graph
 
Reported: 2018-11-04 17:26 PST by Myles C. Maxfield
Modified: 2018-11-19 01:43 PST (History)
12 users (show)

See Also:

Attachments
Patch (40.42 KB, patch)
2018-11-04 17:31 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (37.24 KB, patch)
2018-11-04 18:03 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (37.72 KB, patch)
2018-11-04 18:57 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (37.72 KB, patch)
2018-11-04 19:38 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (40.10 KB, patch)
2018-11-04 22:54 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (41.28 KB, patch)
2018-11-05 09:45 PST, Myles C. Maxfield 		achristensen: review+
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Patch for committing (41.25 KB, patch)
2018-11-05 15:49 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews125 for ios-simulator-wk2 (2.42 MB, application/zip)
2018-11-05 16:20 PST, EWS Watchlist 		no flags Details
Patch for committing (41.03 KB, patch)
2018-11-05 16:23 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Show Obsolete (7) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2018-11-04 17:26:27 PST 
Cache glyph paths and share underline skipping code between all the ports
Comment 1 Myles C. Maxfield 2018-11-04 17:31:19 PST 
Created attachment 353814 [details]
Patch
Comment 2 Myles C. Maxfield 2018-11-04 18:03:09 PST 
Created attachment 353816 [details]
Patch
Comment 3 Myles C. Maxfield 2018-11-04 18:57:42 PST 
Created attachment 353819 [details]
Patch
Comment 4 Myles C. Maxfield 2018-11-04 19:38:45 PST 
Created attachment 353821 [details]
Patch
Comment 5 Myles C. Maxfield 2018-11-04 22:54:22 PST 
Created attachment 353830 [details]
Patch
Comment 6 Myles C. Maxfield 2018-11-05 09:45:20 PST 
Created attachment 353881 [details]
Patch
Comment 7 Alex Christensen 2018-11-05 14:44:35 PST 
Comment on attachment 353881 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353881&action=review

> Source/WebCore/platform/graphics/FontCascade.cpp:1241
> +enum class GlyphUnderlineType {

: uint8_t

> Source/WebCore/platform/graphics/FontCascade.cpp:1669
> +    GlyphIterationState(FloatPoint startingPoint, FloatPoint currentPoint, float y1, float y2, float minX, float maxX)

It seems like this constructor could be omitted by using an initializer list where this constructor is called.
Comment 8 Myles C. Maxfield 2018-11-05 15:49:58 PST 
Created attachment 353916 [details]
Patch for committing
Comment 9 EWS Watchlist 2018-11-05 16:19:58 PST 
Comment on attachment 353881 [details]
Patch

Attachment 353881 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/9870516

New failing tests:
imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription-tracks.https.html
Comment 10 EWS Watchlist 2018-11-05 16:20:00 PST 
Created attachment 353920 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6
Comment 11 Myles C. Maxfield 2018-11-05 16:23:19 PST 
Created attachment 353921 [details]
Patch for committing
Comment 12 Myles C. Maxfield 2018-11-05 20:36:06 PST 
Committed r237845: <https://trac.webkit.org/changeset/237845>
Comment 13 Radar WebKit Bug Importer 2018-11-05 20:37:21 PST 
<rdar://problem/45831149>
Comment 14 Michael Catanzaro 2018-11-16 10:36:38 PST 
It broke the underscore beneath hyperlinks, bug #191630.
Comment 15 Carlos Garcia Campos 2018-11-19 01:43:58 PST 
Comment on attachment 353881 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353881&action=review

> Source/WebCore/platform/graphics/FontCascade.cpp:1751
> +        , m_translation(AffineTransform::translation(textOrigin.x(), textOrigin.y()).scale(1, -1))

This is what broke cairo ports, we didn't have that scale(1, -1) in the cairo impl.