Bug 191239 – Cache glyph paths and share underline skipping code between all the ports

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Myles C. Maxfield]

Cache glyph paths and share underline skipping code between all the ports

[Myles C. Maxfield]

Created attachment 353814 [details]
Patch

[Myles C. Maxfield]

Created attachment 353816 [details]
Patch

[Myles C. Maxfield]

Created attachment 353819 [details]
Patch

[Myles C. Maxfield]

Created attachment 353821 [details]
Patch

[Myles C. Maxfield]

Created attachment 353830 [details]
Patch

[Myles C. Maxfield]

Created attachment 353881 [details]
Patch

[Alex Christensen]

Comment on attachment 353881 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353881&action=review

> Source/WebCore/platform/graphics/FontCascade.cpp:1241
> +enum class GlyphUnderlineType {

: uint8_t

> Source/WebCore/platform/graphics/FontCascade.cpp:1669
> +    GlyphIterationState(FloatPoint startingPoint, FloatPoint currentPoint, float y1, float y2, float minX, float maxX)

It seems like this constructor could be omitted by using an initializer list where this constructor is called.

[Myles C. Maxfield]

Created attachment 353916 [details]
Patch for committing

[EWS Watchlist]

Comment on attachment 353881 [details]
Patch

Attachment 353881 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/9870516

New failing tests:
imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription-tracks.https.html

[EWS Watchlist]

Created attachment 353920 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6

[Myles C. Maxfield]

Created attachment 353921 [details]
Patch for committing

[Myles C. Maxfield]

Committed r237845: <https://trac.webkit.org/changeset/237845>

[Radar WebKit Bug Importer]

<rdar://problem/45831149>

[Michael Catanzaro]

It broke the underscore beneath hyperlinks, bug #191630.

[Carlos Garcia Campos]

Comment on attachment 353881 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353881&action=review

> Source/WebCore/platform/graphics/FontCascade.cpp:1751
> +        , m_translation(AffineTransform::translation(textOrigin.x(), textOrigin.y()).scale(1, -1))

This is what broke cairo ports, we didn't have that scale(1, -1) in the cairo impl.