Bug 191606 - [WPE] Remove glib usage in PlatformKeyboardEventWPE.cpp
Summary: [WPE] Remove glib usage in PlatformKeyboardEventWPE.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-13 15:36 PST by Christopher Reid
Modified: 2018-11-14 08:14 PST (History)
14 users (show)

See Also:


Attachments
patch (3.79 KB, patch)
2018-11-13 15:58 PST, Christopher Reid
ews: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-sierra (2.67 MB, application/zip)
2018-11-13 17:32 PST, Build Bot
no flags Details
Updated patch (2.57 KB, patch)
2018-11-13 17:41 PST, Christopher Reid
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Christopher Reid 2018-11-13 15:36:31 PST
This file is calling glib for converting uint32_t code points to WTFString which doesn't seem necessary.
Comment 1 Christopher Reid 2018-11-13 15:58:56 PST
Created attachment 354719 [details]
patch
Comment 2 Christopher Reid 2018-11-13 16:09:04 PST
For this change, I was wondering if there's a case for using StringBuilder::append(UChar32) with ill-formed utf-32 values.
Comment 3 Christopher Reid 2018-11-13 17:15:08 PST
(In reply to Christopher Reid from comment #2)
> For this change, I was wondering if there's a case for using
> StringBuilder::append(UChar32) with ill-formed utf-32 values.

It seems like CSS.escape does rely on this based on the test failures.
Comment 4 Build Bot 2018-11-13 17:32:51 PST
Comment on attachment 354719 [details]
patch

Attachment 354719 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/9979579

New failing tests:
imported/w3c/web-platform-tests/css/cssom/escape.html
css3/escape-dom-api.html
Comment 5 Build Bot 2018-11-13 17:32:53 PST
Created attachment 354735 [details]
Archive of layout-test-results from ews103 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 6 Christopher Reid 2018-11-13 17:41:39 PST
Created attachment 354737 [details]
Updated patch
Comment 7 Michael Catanzaro 2018-11-13 18:02:18 PST
Comment on attachment 354737 [details]
Updated patch

This looks OK provided the file is first renamed to PlatformKeyboardEventLibWPE.cpp in bug #191401.
Comment 8 Don Olmstead 2018-11-13 18:10:54 PST
(In reply to Michael Catanzaro from comment #7)
> Comment on attachment 354737 [details]
> Updated patch
> 
> This looks OK provided the file is first renamed to
> PlatformKeyboardEventLibWPE.cpp in bug #191401.

Yea I'll be doing that as a followup. This was to prepare it so this can land.
Comment 9 WebKit Commit Bot 2018-11-14 08:13:16 PST
Comment on attachment 354737 [details]
Updated patch

Clearing flags on attachment: 354737

Committed r238175: <https://trac.webkit.org/changeset/238175>
Comment 10 WebKit Commit Bot 2018-11-14 08:13:18 PST
All reviewed patches have been landed.  Closing bug.
Comment 11 Radar WebKit Bug Importer 2018-11-14 08:14:28 PST
<rdar://problem/46063349>