Bug 191401 – Add USE(LIBWPE) to WebCore

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Don Olmstead]

The PlayStation port is planning on having a libwpe implementation but has no plans to use glib.

PLATFORM(WPE) = USE(LIBWPE) + USE(GLIB)
PLATFORM(PLAYSTATION) = USE(LIBWPE)

This will migrate all usage of wpe_* functions to be USE(LIBWPE) rather than PLATFORM(WPE).

[Don Olmstead]

Created attachment 354166 [details]
Patch

[Adrian Perez]

Comment on attachment 354166 [details]
Patch

Reviewing informally... patch looks good to me. Probably it is
a good idea that Žan rubber-stamps this before landing, tho :)

[Michael Catanzaro]

Comment on attachment 354166 [details]
Patch

My only concern is that this is going to introduce some confusion. We're going to be tempted to use GLib in WPE files that can now no longer depend on GLib. So a couple suggestions:

 * Rename GLContextEGLWPE.cpp to GLContextEGLLibwpe.cpp as a reminder that it's now used on non-WPE platforms.
 * Rename PlatformDisplayWPE.cpp to PlatformDisplayLibwpe.cpp for the same reason, and rename the class PlatformDisplayWPE to PlatformDisplayLibwpe.

An alternative spelling would be LibWPE.

See what Zan thinks before making any changes, since he might disagree.

[Zan Dobersek]

(In reply to Michael Catanzaro from comment #3)
>  * Rename GLContextEGLWPE.cpp to GLContextEGLLibwpe.cpp as a reminder that
> it's now used on non-WPE platforms.
>  * Rename PlatformDisplayWPE.cpp to PlatformDisplayLibwpe.cpp for the same
> reason, and rename the class PlatformDisplayWPE to PlatformDisplayLibwpe.
> 
> An alternative spelling would be LibWPE.
> 

These make sense, please apply the renames. I'd personally prefer 'LibWPE', but it's not a strong preference.

[Michael Catanzaro]

(In reply to Zan Dobersek from comment #4)
> These make sense, please apply the renames.

And to all the files using USE(LIBWPE), not just the two I mentioned. (E.g. PlatformKeyboardEventLibWPE.cpp.)

[Don Olmstead]

Created attachment 355007 [details]
Patch

[Don Olmstead]

Created attachment 355008 [details]
Patch

[Don Olmstead]

Ok I think this is good to review. This renames the files and moves to a libwpe location.

[WebKit Commit Bot]

Comment on attachment 355008 [details]
Patch

Clearing flags on attachment: 355008

Committed r238282: <https://trac.webkit.org/changeset/238282>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/46128013>