Bug 191389 - [iOS] Support deleting to the start of the line and to the end of the line
Summary: [iOS] Support deleting to the start of the line and to the end of the line
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Local Build
Hardware: iPhone / iPad iOS 12
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks: 190571
  Show dependency treegraph
 
Reported: 2018-11-07 11:46 PST by Daniel Bates
Modified: 2018-11-07 14:14 PST (History)
3 users (show)

See Also:


Attachments
Patch (1.82 KB, patch)
2018-11-07 11:50 PST, Daniel Bates
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2018-11-07 11:46:18 PST
We should support the key commands to delete to the start of the line and to the end of the line to match platform conventions. The key command to delete to the start of the line and to delete to the end of the line is Command + Delete and Control + K, respectively.
Comment 1 Radar WebKit Bug Importer 2018-11-07 11:46:31 PST
<rdar://problem/45883972>
Comment 2 Daniel Bates 2018-11-07 11:50:43 PST
Created attachment 354120 [details]
Patch

It is not straighforward to test this change. See bug #191381, comment 2.
Comment 3 Daniel Bates 2018-11-07 14:14:24 PST
Comment on attachment 354120 [details]
Patch

Clearing flags on attachment: 354120

Committed r237945: <https://trac.webkit.org/changeset/237945>
Comment 4 Daniel Bates 2018-11-07 14:14:26 PST
All reviewed patches have been landed.  Closing bug.