Bug 191381 - [iOS] Option + Delete should delete previous word
Summary: [iOS] Option + Delete should delete previous word
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Local Build
Hardware: iPhone / iPad iOS 12
: P2 Normal
Assignee: Daniel Bates
Keywords: InRadar
Depends on:
Blocks: 190571
  Show dependency treegraph
Reported: 2018-11-07 10:05 PST by Daniel Bates
Modified: 2018-11-07 14:12 PST (History)
3 users (show)

See Also:

Patch (1.55 KB, patch)
2018-11-07 10:22 PST, Daniel Bates
no flags Details | Formatted Diff | Diff
Patch (1.62 KB, patch)
2018-11-07 11:37 PST, Daniel Bates
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2018-11-07 10:05:30 PST
We should recognize the key command Option + Delete and delete the previous word to more closely match iOS platform conventions.
Comment 1 Daniel Bates 2018-11-07 10:05:48 PST
Comment 2 Daniel Bates 2018-11-07 10:22:32 PST
Created attachment 354104 [details]

It is not straightforward to write a test for this change because UIKit determines the modifier keys pressed (e.g. Option) by querying the keyboard directly. We could mock out the underlying keyboard though this seems fragile.
Comment 3 Daniel Bates 2018-11-07 11:37:35 PST
Created attachment 354116 [details]
Comment 4 Daniel Bates 2018-11-07 14:12:02 PST
Comment on attachment 354116 [details]

Clearing flags on attachment: 354116

Committed r237943: <https://trac.webkit.org/changeset/237943>
Comment 5 Daniel Bates 2018-11-07 14:12:04 PST
All reviewed patches have been landed.  Closing bug.