Bug 191120 - [iOS] Normalize character string based on key code
Summary: [iOS] Normalize character string based on key code
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: iPhone / iPad iOS 12
: P2 Normal
Assignee: Daniel Bates
Keywords: InRadar
Depends on: 189604 190487
Blocks: 190571
  Show dependency treegraph
Reported: 2018-10-31 10:40 PDT by Daniel Bates
Modified: 2018-11-02 10:21 PDT (History)
4 users (show)

See Also:

Patch (7.31 KB, patch)
2018-10-31 10:47 PDT, Daniel Bates
no flags Details | Formatted Diff | Diff
Patch (7.31 KB, patch)
2018-10-31 10:49 PDT, Daniel Bates
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2018-10-31 10:40:26 PDT
Following the fix for bug #189604, WebKit always has a key code for special keyboard keys (e.g. page up) and hence we can remove the need to perform string comparison when normalizing character strings.
Comment 1 Daniel Bates 2018-10-31 10:47:38 PDT
Created attachment 353503 [details]
Comment 2 Daniel Bates 2018-10-31 10:49:01 PDT
Created attachment 353504 [details]
Comment 3 Daniel Bates 2018-11-01 09:27:54 PDT
Patch does not apply because it depends on the patch for bug #190487.
Comment 4 Tim Horton 2018-11-01 16:25:20 PDT
Comment on attachment 353504 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=353504&action=review

> Source/WebCore/platform/ios/WebEvent.mm:127
> +static NSString* normalizedStringWithAppKitCompatibilityMapping(NSString *characters, uint16_t keyCode)

Not new, but star's on the wrong side.
Comment 5 Daniel Bates 2018-11-02 10:20:36 PDT
Committed r237739: <https://trac.webkit.org/changeset/237739>
Comment 6 Radar WebKit Bug Importer 2018-11-02 10:21:46 PDT