Bug 190487 – [iOS] WebKit should dispatch DOM events when a modifier key is pressed

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Daniel Bates]

Part of <rdar://problem/44930119>.

Add support for recognizing WebEvents that represent changes to modifier flags (e.g. the Command key).

[Daniel Bates]

Created attachment 352104 [details]
Patch

[Daniel Bates]

Created attachment 353432 [details]
Patch and test

Updated patch a similar change to -[WebEvent initWithKeyEventType:timeStamp:characters:charactersIgnoringModifiers:modifiers:isRepeating:withFlags:withInputManagerHint:keyCode:isTabKey:] as I did for -[WebEvent initWithKeyEventType:timeStamp:characters:charactersIgnoringModifiers:modifiers:isRepeating:withFlags:keyCode:isTabKey:characterSet:].

[Tim Horton]

Comment on attachment 353432 [details]
Patch and test

View in context: https://bugs.webkit.org/attachment.cgi?id=353432&action=review

> Source/WebCore/platform/ios/WebEvent.h:59
> +// These enum values are copied directly from GSEvent for compatibility.

Really?

> Source/WebCore/platform/ios/WebEvent.h:87
> +// These enum values are copied directly from GSEvent for compatibility.

Don't look "copied directly" to me.

> Tools/ChangeLog:8
> +        Update the code for renamed enumerators. For WebKitTestRunner, removed comment that does not

Is this "enumerations" not "enumerators"?

[Daniel Bates]

Comment on attachment 353432 [details]
Patch and test

View in context: https://bugs.webkit.org/attachment.cgi?id=353432&action=review

>> Source/WebCore/platform/ios/WebEvent.h:59
>> +// These enum values are copied directly from GSEvent for compatibility.
> 
> Really?

Copied and renamed just like all the other enums in this file that have the same comment above them. I take it you would like the comment to be more precise. Before landing I will change this comment and all added comments to read: "These enum values correspond to the kGSEvent* enumerators for compatibility."

[Daniel Bates]

(In reply to Daniel Bates from comment #4)
> Comment on attachment 353432 [details]
> Patch and test
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=353432&action=review
> 
> >> Source/WebCore/platform/ios/WebEvent.h:59
> >> +// These enum values are copied directly from GSEvent for compatibility.
> > 
> > Really?
> 
> Copied and renamed just like all the other enums in this file that have the
> same comment above them. I take it you would like the comment to be more
> precise. Before landing I will change this comment and all added comments to
> read: "These enum values correspond to the kGSEvent* enumerators for
> compatibility."

Will be even more precise and reference the framework that has these enumerators:

These enum values correspond to the GraphicsServices kGSEventFlagMask* enumerators for compatibility.

Will also change the comment "These enum values are copied directly from GSEvent for compatibility." above the WebEventCharacterSet enum to read "These enum values correspond to the GraphicsServices kGSCharacterSet* constants for compatibility." before landing.

[Daniel Bates]

Committed r237738: <https://trac.webkit.org/changeset/237738>

[Daniel Bates]

(In reply to Tim Horton from comment #3)
> > Tools/ChangeLog:8
> > +        Update the code for renamed enumerators. For WebKitTestRunner, removed comment that does not
> 
> Is this "enumerations" not "enumerators"?

For completeness, I fixed this in this ChangeLog and all other ChangeLogs in this patch.