Bug 191101 - [Win] Use C++14, not C++17
Summary: [Win] Use C++14, not C++17
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-30 22:42 PDT by Fujii Hironori
Modified: 2018-11-04 20:40 PST (History)
6 users (show)

See Also:

Attachments
Patch (5.27 KB, patch)
2018-10-30 22:54 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2018-10-30 22:42:51 PDT 
[Win] Use C++14, not C++17

Based on the webkit-dev discussion, I'd like to switch Windows port from C++17 to C++14.

[webkit-dev] MSVC and the state of C++17
https://lists.webkit.org/pipermail/webkit-dev/2018-September/030186.html

See also:

Bug 185232 – [Win] Use C++17 in MSVC
Comment 1 Fujii Hironori 2018-10-30 22:54:59 PDT 
Created attachment 353465 [details]
Patch
Comment 2 Ross Kirsling 2018-10-30 23:00:01 PDT 
Comment on attachment 353465 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353465&action=review

> Tools/MiniBrowser/win/WebKitBrowserWindow.cpp:41
> +    std::vector<WKChar> wkCharBuffer(maxSize);

Should this be a WTF::Vector instead?
Comment 3 Fujii Hironori 2018-10-30 23:06:33 PDT 
Comment on attachment 353465 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353465&action=review

>> Tools/MiniBrowser/win/WebKitBrowserWindow.cpp:41
>> +    std::vector<WKChar> wkCharBuffer(maxSize);
> 
> Should this be a WTF::Vector instead?

The reason why I don't want to use WTF in MiniBrowser is that I want to use only public API (WK1 and WK2) in MiniBrowser as much as possible.
But, this is just my opinion, MiniBrowser is including some WebCore headers.
See also Bug 190791.
Comment 4 Fujii Hironori 2018-11-04 20:39:28 PST 
Comment on attachment 353465 [details]
Patch

Clearing flags on attachment: 353465

Committed r237789: <https://trac.webkit.org/changeset/237789>
Comment 5 Fujii Hironori 2018-11-04 20:39:31 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-11-04 20:40:19 PST 
<rdar://problem/45797939>