Bug 191101 – [Win] Use C++14, not C++17

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Fujii Hironori]

[Win] Use C++14, not C++17

Based on the webkit-dev discussion, I'd like to switch Windows port from C++17 to C++14.

[webkit-dev] MSVC and the state of C++17
https://lists.webkit.org/pipermail/webkit-dev/2018-September/030186.html

See also:

Bug 185232 – [Win] Use C++17 in MSVC

[Fujii Hironori]

Created attachment 353465 [details]
Patch

[Ross Kirsling]

Comment on attachment 353465 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353465&action=review

> Tools/MiniBrowser/win/WebKitBrowserWindow.cpp:41
> +    std::vector<WKChar> wkCharBuffer(maxSize);

Should this be a WTF::Vector instead?

[Fujii Hironori]

Comment on attachment 353465 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353465&action=review

>> Tools/MiniBrowser/win/WebKitBrowserWindow.cpp:41
>> +    std::vector<WKChar> wkCharBuffer(maxSize);
> 
> Should this be a WTF::Vector instead?

The reason why I don't want to use WTF in MiniBrowser is that I want to use only public API (WK1 and WK2) in MiniBrowser as much as possible.
But, this is just my opinion, MiniBrowser is including some WebCore headers.
See also Bug 190791.

[Fujii Hironori]

Comment on attachment 353465 [details]
Patch

Clearing flags on attachment: 353465

Committed r237789: <https://trac.webkit.org/changeset/237789>

[Fujii Hironori]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/45797939>