[Win] Use C++17 in MSVC
Created attachment 339374 [details] Patch
Created attachment 339375 [details] Patch
Created attachment 339378 [details] Patch
Created attachment 339386 [details] Patch
Attachment 339386 [details] did not pass style-queue: ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:2839: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:2954: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3086: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3237: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3406: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3592: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3795: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4017: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4256: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4518: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4518: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4540: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4540: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4565: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4565: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4592: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4592: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4623: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4623: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4656: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4694: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4735: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4779: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 23 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 339395 [details] Patch
Attachment 339395 [details] did not pass style-queue: ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:2839: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:2954: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3086: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3237: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3406: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3592: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3795: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4017: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4256: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4518: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4518: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4540: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4540: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4565: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4565: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4592: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4592: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4623: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4623: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4656: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4694: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4735: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4779: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 23 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 339400 [details] Patch
Attachment 339400 [details] did not pass style-queue: ERROR: Tools/DumpRenderTree/win/TextInputControllerWin.cpp:122: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:2839: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:2954: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3086: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3237: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3406: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3592: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3795: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4017: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4256: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4518: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4518: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4540: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4540: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4565: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4565: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4592: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4592: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4623: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4623: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4656: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4694: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4735: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4779: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 24 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 339499 [details] Patch
Attachment 339499 [details] did not pass style-queue: ERROR: Tools/DumpRenderTree/win/TextInputControllerWin.cpp:122: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:2839: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:2954: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3086: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3237: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3406: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3592: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3795: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4017: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4256: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4518: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4518: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4540: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4540: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4565: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4565: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4592: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4592: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4623: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4623: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4656: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4694: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4735: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4779: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 24 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 339675 [details] Patch
Attachment 339675 [details] did not pass style-queue: ERROR: Tools/DumpRenderTree/win/TextInputController.h:47: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Tools/DumpRenderTree/win/TextInputControllerWin.cpp:122: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:2839: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:2954: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3086: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3237: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3406: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3592: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3795: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4017: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4256: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4518: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4518: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4540: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4540: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4565: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4565: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4592: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4592: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4623: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4623: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4656: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4694: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4735: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4779: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 25 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 339677 [details] Patch
Attachment 339677 [details] did not pass style-queue: ERROR: Tools/DumpRenderTree/win/TextInputController.h:47: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Tools/DumpRenderTree/win/TextInputControllerWin.cpp:122: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:2839: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:2954: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3086: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3237: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3406: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3592: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3795: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4017: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4256: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4518: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4518: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4540: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4540: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4565: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4565: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4592: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4592: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4623: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4623: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4656: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4694: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4735: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4779: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 25 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 339678 [details] Patch
Attachment 339678 [details] did not pass style-queue: ERROR: Tools/DumpRenderTree/win/TextInputController.h:47: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Tools/DumpRenderTree/win/TextInputControllerWin.cpp:122: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:2839: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:2954: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3086: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3237: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3406: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3592: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3795: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4017: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4256: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4518: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4518: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4540: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4540: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4565: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4565: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4592: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4592: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4623: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4623: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4656: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4694: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4735: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4779: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 25 in 16 files If any of these errors are false positives, please file a bug against check-webkit-style.
OK, windows bots are green :D Ready for review.
Comment on attachment 339678 [details] Patch Attachment 339678 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/7584623 New failing tests: webanimations/opacity-animation-no-longer-composited-upon-completion.html http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-audio.html http/tests/security/contentSecurityPolicy/script-src-parsing-implicit-and-explicit-port-number.html http/tests/security/contentSecurityPolicy/script-src-redirect.html webanimations/css-animations.html webanimations/width-and-opacity-separate-animation-yields-no-compositing.html
Created attachment 339679 [details] Archive of layout-test-results from ews200 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews200 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Created attachment 339680 [details] Patch
Attachment 339680 [details] did not pass style-queue: ERROR: Tools/DumpRenderTree/win/TextInputController.h:47: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Tools/DumpRenderTree/win/TextInputControllerWin.cpp:122: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:2839: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:2954: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3086: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3237: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3406: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3592: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3795: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4017: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4256: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4518: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4518: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4540: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4540: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4565: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4565: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4592: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4592: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4623: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4623: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4656: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4694: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4735: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4779: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 25 in 16 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 339680 [details] Patch Attachment 339680 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/7585570 New failing tests: http/tests/security/contentSecurityPolicy/script-src-redirect.html webanimations/css-animations.html webanimations/opacity-animation-no-longer-composited-upon-completion.html webanimations/width-and-opacity-separate-animation-yields-no-compositing.html http/tests/security/contentSecurityPolicy/script-src-parsing-implicit-and-explicit-port-number.html
Created attachment 339682 [details] Archive of layout-test-results from ews200 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews200 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment on attachment 339680 [details] Patch Attachment 339680 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/7586223 New failing tests: http/tests/security/contentSecurityPolicy/script-src-redirect.html webanimations/css-animations.html webanimations/opacity-animation-no-longer-composited-upon-completion.html webanimations/width-and-opacity-separate-animation-yields-no-compositing.html http/tests/security/contentSecurityPolicy/script-src-parsing-implicit-and-explicit-port-number.html
Created attachment 339685 [details] Archive of layout-test-results from ews201 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews201 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Any theories on why the tests are failing?
(In reply to Darin Adler from comment #27) > Any theories on why the tests are failing? Several theories can be considered, but it is quite difficult to investigate the reason without the actual environment. Can any AppleWin maintainers check the crashes? 1. std::optional use is wrong If the existing code uses std::optional wrongly, it causes a bug when we switch std::optional from our own one to MSVC's one. 2. std::optional in MSVC is wrong If MSVC's std::optional implementation has a bug, it causes a bug. 3. MSVC C++17 implementation has a bug If MSVC has a bug when using C++17, it causes a bug. 4. std::optional's ABI compatibility with the existing Windows support library If some of Windows support libraries use std::optional for their API, we need to rebuild it when switching std::optional from our own one to MSVC's one.
(In reply to Yusuke Suzuki from comment #28) > (In reply to Darin Adler from comment #27) > > Any theories on why the tests are failing? > > Several theories can be considered, but it is quite difficult to investigate > the reason without the actual environment. > Can any AppleWin maintainers check the crashes? > > 1. std::optional use is wrong > > If the existing code uses std::optional wrongly, it causes a bug when we > switch std::optional from our own one to MSVC's one. > > 2. std::optional in MSVC is wrong > > If MSVC's std::optional implementation has a bug, it causes a bug. > > 3. MSVC C++17 implementation has a bug > > If MSVC has a bug when using C++17, it causes a bug. > > 4. std::optional's ABI compatibility with the existing Windows support > library > > If some of Windows support libraries use std::optional for their API, we > need to rebuild it when switching std::optional from our own one to MSVC's > one. A new version of VS 2017 dropped today https://blogs.msdn.microsoft.com/visualstudio/2018/05/07/visual-studio-2017-version-15-7-and-version-15-8-preview-1/ so if its 3. it might be worth looking at it after the update.
It's pretty weird that std::optional is causing us such a huge amount of trouble in so many bugs.
Comment on attachment 339680 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=339680&action=review Can someone on the Apple side verify what version of MSVC their bots are on? The latest version 15.7 has a lot more C++17 conformance. > Source/WTF/wtf/StdLibExtras.h:546 > +#if __cplusplus < 201703L && (!defined(_MSC_FULL_VER) || _MSC_FULL_VER < 190023918) It looks like we can technically get rid of the MSVS checks here https://blogs.msdn.microsoft.com/vcblog/2018/04/09/msvc-now-correctly-reports-__cplusplus/
Comment on attachment 339680 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=339680&action=review > Source/WTF/wtf/Optional.h:51 > -#if !COMPILER(MSVC) && !PLATFORM(COCOA) && __has_include(<optional>) > +#if !PLATFORM(COCOA) && __has_include(<optional>) > # include <optional> If std::optional is causing us so many problems, we could probably land everything but this, then do the std::optional change in a follow-up patch.
(In reply to Alex Christensen from comment #32) > Comment on attachment 339680 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=339680&action=review > > > Source/WTF/wtf/Optional.h:51 > > -#if !COMPILER(MSVC) && !PLATFORM(COCOA) && __has_include(<optional>) > > +#if !PLATFORM(COCOA) && __has_include(<optional>) > > # include <optional> > > If std::optional is causing us so many problems, we could probably land > everything but this, then do the std::optional change in a follow-up patch. The problematic thing is that we are not sure whether std::optional is an actual problem... And I'm not sure we can compile it without using system std::optional: for example it redefines std::optional if some system header includes <optional> internally. Anyway, I'll try it :)
Created attachment 340336 [details] Patch
Attachment 340336 [details] did not pass style-queue: ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:2839: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:2954: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3086: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3237: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3406: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3592: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:3795: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4017: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4256: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4518: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4518: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4540: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4540: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4565: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4565: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4592: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4592: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4623: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4623: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4656: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4694: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4735: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/gtest/include/gtest/internal/gtest-param-util-generated.h:4779: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/DumpRenderTree/win/TextInputController.h:47: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Tools/DumpRenderTree/win/TextInputControllerWin.cpp:122: Omit int when using unsigned [runtime/unsigned] [1] Total errors found: 25 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.
Seeing the log in AppleWin, this patch now works well. We do not use std::optional in MSVC right now. Ready for reviews :) (In reply to Don Olmstead from comment #31) > Comment on attachment 339680 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=339680&action=review > > Can someone on the Apple side verify what version of MSVC their bots are on? > The latest version 15.7 has a lot more C++17 conformance. Can we do this? > > > Source/WTF/wtf/StdLibExtras.h:546 > > +#if __cplusplus < 201703L && (!defined(_MSC_FULL_VER) || _MSC_FULL_VER < 190023918) > > It looks like we can technically get rid of the MSVS checks here > https://blogs.msdn.microsoft.com/vcblog/2018/04/09/msvc-now-correctly- > reports-__cplusplus/ Once MSVC is updated, we will use this and remove these checks!
Committed r231852: <https://trac.webkit.org/changeset/231852>
<rdar://problem/40299634>