Bug 191063 - Static global 'fastHandlerInstalled' conditionally declared in WasmFaultSignalHandler.cpp
Summary: Static global 'fastHandlerInstalled' conditionally declared in WasmFaultSigna...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-30 05:10 PDT by Jim Mason
Modified: 2018-10-31 03:12 PDT (History)
8 users (show)

See Also:

Attachments
Patch (1.36 KB, patch)
2018-10-30 05:22 PDT, Jim Mason 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jim Mason 2018-10-30 05:10:17 PDT 
The static global variable 'fastHandlerInstalled' is declared inside an #if block in WasmFaultSignalHandler.cpp, but referenced later outside it.  This results in a compilation error when the #if condition is not met.

In this specific case, the combination of conditions which result in the error are ENABLE(WEBASSEMBLY) and !ENABLE(WEBASSEMBLY_FAST_MEMORY).

Rescoping the declaration outside the #if block resolves the problem.
Comment 1 Jim Mason 2018-10-30 05:22:42 PDT 
Created attachment 353362 [details]
Patch
Comment 2 Yusuke Suzuki 2018-10-30 05:30:51 PDT 
Comment on attachment 353362 [details]
Patch

r=me
Comment 3 Jim Mason 2018-10-31 02:22:11 PDT 
Closed by mistake.  Reopening for commit bot.
Comment 4 WebKit Commit Bot 2018-10-31 03:10:04 PDT 
The commit-queue encountered the following flaky tests while processing attachment 353362 [details]:

http/wpt/css/css-animations/start-animation-001.html bug 190903 (authors: dino@apple.com, fred.wang@free.fr, and graouts@apple.com)
The commit-queue is continuing to process your patch.
Comment 5 WebKit Commit Bot 2018-10-31 03:10:53 PDT 
Comment on attachment 353362 [details]
Patch

Clearing flags on attachment: 353362

Committed r237630: <https://trac.webkit.org/changeset/237630>
Comment 6 WebKit Commit Bot 2018-10-31 03:10:55 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-10-31 03:12:38 PDT 
<rdar://problem/45696235>