Bug 190911 - Modernize WebKit nibs and lprojs for localization's sake
Summary: Modernize WebKit nibs and lprojs for localization's sake
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-25 11:24 PDT by Tim Horton
Modified: 2018-10-29 14:22 PDT (History)
5 users (show)

See Also:


Attachments
Patch (251.92 KB, patch)
2018-10-25 11:25 PDT, Tim Horton
no flags Details | Formatted Diff | Diff
Patch (254.00 KB, patch)
2018-10-25 12:00 PDT, Tim Horton
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2018-10-25 11:24:08 PDT
Modernize WebKit nibs and lprojs for localization's sake
Comment 1 Tim Horton 2018-10-25 11:25:12 PDT
Created attachment 353095 [details]
Patch
Comment 2 Tim Horton 2018-10-25 11:25:14 PDT
<rdar://problem/45349466>
Comment 3 Beth Dakin 2018-10-25 11:29:21 PDT
Comment on attachment 353095 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353095&action=review

> Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:-9991
> -				Japanese,

Is it a problem to remove these other regions?
Comment 4 Tim Horton 2018-10-25 11:59:04 PDT
I don't think so.
Comment 5 Tim Horton 2018-10-25 12:00:31 PDT
Created attachment 353099 [details]
Patch
Comment 6 mitz 2018-10-25 12:06:01 PDT
The attached diff appears to confuse the diff prettifier.
Comment 7 mitz 2018-10-25 12:10:09 PDT
(In reply to mitz from comment #6)
> The attached diff appears to confuse the diff prettifier.

Never mind. Something was broken in my web browser causing the pretty diff to be truncated.
Comment 8 mitz 2018-10-26 11:06:33 PDT
Comment on attachment 353099 [details]
Patch

rs=me

Please use svn (or the commit queue?) to land this so that any now-empty directories are deleted from the repository.
Comment 9 WebKit Commit Bot 2018-10-29 14:22:54 PDT
Comment on attachment 353099 [details]
Patch

Clearing flags on attachment: 353099

Committed r237566: <https://trac.webkit.org/changeset/237566>
Comment 10 WebKit Commit Bot 2018-10-29 14:22:56 PDT
All reviewed patches have been landed.  Closing bug.