Bug 190639 – WebKit project should switch from English.lproj to en.lproj

• Status: NEW
• Component: Platform

[Remy Demarest]

We should switch WebKit projects from English.lproj, which has been deprecated for a decade, to en.lproj.

[Remy Demarest]

<rdar://problem/45317521>

[Remy Demarest]

Created attachment 352836 [details]
Patch

[EWS Watchlist]

Attachment 352836 [details] did not pass style-queue:


ERROR: Source/WebCore/WebCore.xcodeproj/project.pbxproj:31686:  developmentRegion is not English.  [xcodeproj/settings] [5]
ERROR: Source/WebInspectorUI/WebInspectorUI.xcodeproj/project.pbxproj:111:  developmentRegion is not English.  [xcodeproj/settings] [5]
ERROR: Source/WebKit/WebKit.xcodeproj/project.pbxproj:10000:  developmentRegion is not English.  [xcodeproj/settings] [5]
ERROR: Source/WebKitLegacy/WebKitLegacy.xcodeproj/project.pbxproj:3228:  developmentRegion is not English.  [xcodeproj/settings] [5]
Total errors found: 4 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EWS Watchlist]

Comment on attachment 352836 [details]
Patch

Attachment 352836 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/9672788

New failing tests:
media/modern-media-controls/localized-strings/replaced-string.html

[EWS Watchlist]

Created attachment 352842 [details]
Archive of layout-test-results from ews101 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 352836 [details]
Patch

Attachment 352836 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/9672832

New failing tests:
media/modern-media-controls/localized-strings/replaced-string.html

[EWS Watchlist]

Created attachment 352844 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 352836 [details]
Patch

Attachment 352836 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/9673052

New failing tests:
media/modern-media-controls/localized-strings/replaced-string.html

[EWS Watchlist]

Created attachment 352846 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 352836 [details]
Patch

Attachment 352836 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/9673050

New failing tests:
media/modern-media-controls/localized-strings/replaced-string.html

[EWS Watchlist]

Created attachment 352847 [details]
Archive of layout-test-results from ews112 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-sierra  Platform: Mac OS X 10.12.6

[Alex Christensen]

Comment on attachment 352836 [details]
Patch

This has been requesting review for more than one year.  If this is still needed, please rebase and re-request review.