Bug 190900 - [WPE][GTK] Follow-up fixes to the certificate coders
Summary: [WPE][GTK] Follow-up fixes to the certificate coders
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WPE WebKit (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Claudio Saavedra
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-25 02:51 PDT by Claudio Saavedra
Modified: 2018-10-25 08:55 PDT (History)
3 users (show)

See Also:


Attachments
Patch (3.89 KB, patch)
2018-10-25 02:52 PDT, Claudio Saavedra
no flags Details | Formatted Diff | Diff
Patch for landing (3.89 KB, patch)
2018-10-25 08:07 PDT, Claudio Saavedra
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Claudio Saavedra 2018-10-25 02:51:32 PDT
[WPE][GTK] Follow-up fixes to the certificate coders
Comment 1 Claudio Saavedra 2018-10-25 02:52:35 PDT
Created attachment 353080 [details]
Patch
Comment 2 Michael Catanzaro 2018-10-25 07:42:29 PDT
Comment on attachment 353080 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353080&action=review

Yeah, this looks better!

> Source/WebKit/ChangeLog:11
> +        cropped chain.
> +        * Shared/soup/WebCoreArgumentCodersSoup.cpp:

Missing blank line here
Comment 3 Claudio Saavedra 2018-10-25 08:07:11 PDT
Created attachment 353084 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2018-10-25 08:55:00 PDT
The commit-queue encountered the following flaky tests while processing attachment 353084 [details]:

http/wpt/css/css-animations/start-animation-001.html bug 190903 (authors: dino@apple.com, fred.wang@free.fr, and graouts@apple.com)
The commit-queue is continuing to process your patch.
Comment 5 WebKit Commit Bot 2018-10-25 08:55:42 PDT
Comment on attachment 353084 [details]
Patch for landing

Clearing flags on attachment: 353084

Committed r237415: <https://trac.webkit.org/changeset/237415>
Comment 6 WebKit Commit Bot 2018-10-25 08:55:44 PDT
All reviewed patches have been landed.  Closing bug.