Bug 19086 - REGRESSION (r28519-r28535): Caret doesn't paint past the right edge of a block
: REGRESSION (r28519-r28535): Caret doesn't paint past the right edge of a block
Status: RESOLVED FIXED
: WebKit
Layout and Rendering
: 528+ (Nightly build)
: Macintosh Mac OS X 10.5
: P1 Normal
Assigned To:
: data:text/html,%3Cdiv%20contenteditab...
: GoogleBug, HasReduction, InRadar, Reg...
:
:
  Show dependency treegraph
 
Reported: 2008-05-15 13:39 PST by
Modified: 2008-05-25 13:15 PST (History)


Attachments
Revert part of r28523 (14.61 KB, patch)
2008-05-25 13:00 PST, mitz@webkit.org
darin: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2008-05-15 13:39:25 PST
When the caret position is past the right edge of a block, it does not always paint (it paints when it moves or changes, but not when it should blink). This happens at the end of a line of right-aligned text (or the beginning of right-aligned RTL text).

To reproduce:
1. Open the URL
2. Click near the top of the document
3. Type some text
------- Comment #1 From 2008-05-25 10:14:51 PST -------
<rdar://problem/5962254>
------- Comment #2 From 2008-05-25 10:15:05 PST -------
*** Bug 19244 has been marked as a duplicate of this bug. ***
------- Comment #3 From 2008-05-25 10:19:21 PST -------
Probably a result of removing the padding in <http://trac.webkit.org/changeset/28523>.
------- Comment #4 From 2008-05-25 11:05:43 PST -------
Internal autospade says:

Works: r28519  Fails: r28535
------- Comment #5 From 2008-05-25 13:00:49 PST -------
Created an attachment (id=21339) [details]
Revert part of r28523

This patch fixes the regression. Its weakness is that it only covers cases where the caret is within one pixel from the block, but I could not come up with a reasonable general solution. I am not sure that it is ever valid for the caret to be more than one pixel away from the block.
------- Comment #6 From 2008-05-25 13:09:14 PST -------
(From update of attachment 21339 [details])
+    // Ensure that the dirty rect intersects the blcok that paints the caret even in the case where

Typo "blcok".

r=me
------- Comment #7 From 2008-05-25 13:15:02 PST -------
Fixed in <http://trac.webkit.org/changeset/34127>.