Bug 190678 - [GStreamer][WebRTC] Error out when simulcast is activated
Summary: [GStreamer][WebRTC] Error out when simulcast is activated
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Thibault Saunier
URL:
Keywords: InRadar
Depends on: 190677
Blocks: 187064 190035
  Show dependency tree / graph
 
Reported: 2018-10-17 12:19 PDT by Thibault Saunier
Modified: 2018-11-05 08:09 PST (History)
4 users (show)

See Also:

Attachments
Patch (4.50 KB, patch)
2018-10-17 12:20 PDT, Thibault Saunier 		no flags Details | Formatted Diff | Diff
Patch (4.50 KB, patch)
2018-10-17 12:21 PDT, Thibault Saunier 		no flags Details | Formatted Diff | Diff
Patch for landing (3.77 KB, patch)
2018-11-05 07:29 PST, Thibault Saunier 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thibault Saunier 2018-10-17 12:19:35 PDT 
[GStreamer][WebRTC] Error out when simulcast is activate
Comment 1 Thibault Saunier 2018-10-17 12:20:24 PDT 
Created attachment 352610 [details]
Patch
Comment 2 Thibault Saunier 2018-10-17 12:21:42 PDT 
Created attachment 352611 [details]
Patch
Comment 3 WebKit Commit Bot 2018-11-05 06:52:32 PST 
Comment on attachment 352611 [details]
Patch

Rejecting attachment 352611 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 352611, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as commit-queue@webkit.org...
Fetching: https://bugs.webkit.org/attachment.cgi?id=352611&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=190678&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Updating working directory
Processing patch 352611 from bug 190678.
Fetching: https://bugs.webkit.org/attachment.cgi?id=352611
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/platform/gtk/TestExpectations', u'LayoutTests/platform/wpe/TestExpectations']" exit_code: 1

ERROR: /Volumes/Data/EWS/WebKit/LayoutTests/platform/gtk/TestExpectations:3594:  Duplicate or ambiguous entry lines LayoutTests/platform/gtk/TestExpectations:568 and LayoutTests/platform/gtk/TestExpectations:3594.  [test/expectations] [5]
Total errors found: 1 in 2 files

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/platform/gtk/TestExpectations', u'LayoutTests/platform/wpe/TestExpectations']" exit_code: 1

ERROR: /Volumes/Data/EWS/WebKit/LayoutTests/platform/gtk/TestExpectations:3594:  Duplicate or ambiguous entry lines LayoutTests/platform/gtk/TestExpectations:568 and LayoutTests/platform/gtk/TestExpectations:3594.  [test/expectations] [5]
Total errors found: 1 in 2 files

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/platform/gtk/TestExpectations', u'LayoutTests/platform/wpe/TestExpectations']" exit_code: 1
Updating OpenSource
Current branch master is up to date.
ERROR: /Volumes/Data/EWS/WebKit/LayoutTests/platform/gtk/TestExpectations:3594:  Duplicate or ambiguous entry lines LayoutTests/platform/gtk/TestExpectations:568 and LayoutTests/platform/gtk/TestExpectations:3594.  [test/expectations] [5]
Total errors found: 1 in 2 files

Full output: https://webkit-queues.webkit.org/results/9864867
Comment 4 Thibault Saunier 2018-11-05 07:29:54 PST 
Created attachment 353862 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2018-11-05 08:08:21 PST 
Comment on attachment 353862 [details]
Patch for landing

Clearing flags on attachment: 353862

Committed r237804: <https://trac.webkit.org/changeset/237804>
Comment 6 WebKit Commit Bot 2018-11-05 08:08:23 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-11-05 08:09:22 PST 
<rdar://problem/45807516>