Bug 190677 - [GStreamer] Do not sync libwerbtc stream on the clock
Summary: [GStreamer] Do not sync libwerbtc stream on the clock
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Thibault Saunier
URL:
Keywords: InRadar
Depends on: 190676
Blocks: 187064 190678
  Show dependency tree / graph
 
Reported: 2018-10-17 12:12 PDT by Thibault Saunier
Modified: 2018-11-05 06:51 PST (History)
4 users (show)

See Also:

Attachments
Patch (3.91 KB, patch)
2018-10-17 12:15 PDT, Thibault Saunier 		no flags Details | Formatted Diff | Diff
Patch (3.92 KB, patch)
2018-10-31 04:25 PDT, Thibault Saunier 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thibault Saunier 2018-10-17 12:12:21 PDT 
[GStreamer] Do not sync libwerbtc stream on the clock
Comment 1 Thibault Saunier 2018-10-17 12:15:37 PDT 
Created attachment 352608 [details]
Patch
Comment 2 Philippe Normand 2018-10-18 02:30:07 PDT 
Comment on attachment 352608 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=352608&action=review

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:250
> +static void setSyncOnSink(GstElement *element, bool sync)

Misplaced *. Also sorry for being nitpicky about the name, may I suggest setSyncPropertyOnSink ?
Comment 3 Thibault Saunier 2018-10-18 05:33:27 PDT 
(In reply to Philippe Normand from comment #2)
> Comment on attachment 352608 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=352608&action=review
> 
> > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:250
> > +static void setSyncOnSink(GstElement *element, bool sync)
> 
> Misplaced *. Also sorry for being nitpicky about the name, may I suggest
> setSyncPropertyOnSink ?

I do not get when the style checkers report this issue and when not (looks like there is a bug :-).

What about `setSyncOnClock()` ?
Comment 4 Philippe Normand 2018-10-18 05:38:08 PDT 
(In reply to Thibault Saunier from comment #3)
> (In reply to Philippe Normand from comment #2)
> > Comment on attachment 352608 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=352608&action=review
> > 
> > > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:250
> > > +static void setSyncOnSink(GstElement *element, bool sync)
> > 
> > Misplaced *. Also sorry for being nitpicky about the name, may I suggest
> > setSyncPropertyOnSink ?
> 
> I do not get when the style checkers report this issue and when not (looks
> like there is a bug :-).
> 
> What about `setSyncOnClock()` ?

OK
Comment 5 Thibault Saunier 2018-10-31 04:25:42 PDT 
Created attachment 353487 [details]
Patch

Renamed syncOnSink to syncOnClock
Comment 6 WebKit Commit Bot 2018-11-05 06:50:37 PST 
Comment on attachment 353487 [details]
Patch

Clearing flags on attachment: 353487

Committed r237799: <https://trac.webkit.org/changeset/237799>
Comment 7 WebKit Commit Bot 2018-11-05 06:50:38 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2018-11-05 06:51:25 PST 
<rdar://problem/45806287>