compositing/repaint/iframes/compositing-iframe-scroll-repaint.html is flakey (maybe only with the patch from bug 90342). When it breaks, the compositing layer already has a repaint, so in GraphicsLayerCA::setNeedsDisplayInRect() the dirty rects already contain the rect and we bail. This suggests that testRunner.displayAndTrackRepaints() isn't triggering paints in all compositing layers in WK1; need to see if we're flushing layers at all in that code path.
<rdar://problem/45466143>
The following tests were marked flaky in Mojave WK1 compositing/masks/compositing-clip-path-change-no-repaint.html compositing/repaint/iframes/compositing-iframe-scroll-repaint.html compositing/repaint/iframes/compositing-iframe-with-fixed-background-doc-repaint.html revision: https://trac.webkit.org/changeset/237333/webkit
It looks like we never get a -viewWillDraw after the load event and before zero-delay timers, which is controlled by whether runloop observers fire at that time; they may not if there is no idle phase in the runloop.
Created attachment 354069 [details] Patch
Comment on attachment 354069 [details] Patch Attachment 354069 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9891094 New failing tests: compositing/columns/composited-rl-paginated-repaint.html compositing/repaint/repaint-on-layer-grouping-change.html compositing/columns/composited-lr-paginated-repaint.html
Created attachment 354077 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
https://trac.webkit.org/r237942
*** Bug 189841 has been marked as a duplicate of this bug. ***
*** Bug 189752 has been marked as a duplicate of this bug. ***
Since this issue persists, updating test expectations.
Test gardening commit 268204@main (d4d29cc87cd9): <https://commits.webkit.org/268204@main> Reviewed commits have been landed. Closing PR #17976 and removing active labels.
Issue persists (and has further regressed) in macOS Sonoma. This test is now a consistent failure on the following platforms: - wk1 release - iOS 16+ wk2 release - Sonoma+ wk2 release. Filing new expectations under this bug and duping bug #177397 to this one.
CLARIFICATION: compositing/masks/compositing-clip-path-change-no-repaint.html is now a consistent failure on the following platforms: - macOS wk1 release - iOS wk2 release - Sonoma+ wk2 release. I will create a new bug for this one. The following tests are constantly failing on Sonoma wk1 and iOS wk2: compositing/repaint/iframes/compositing-iframe-scroll-repaint.html compositing/repaint/iframes/compositing-iframe-with-fixed-background-doc-repaint.html -> No action needed, as expectations already cover these tests. Verified issue resolved: compositing/columns/composited-lr-paginated-repaint.html compositing/columns/composited-rl-paginated-repaint.html compositing/repaint/repaint-on-layer-grouping-change.html