Their GStreamer version is too old.
Created attachment 352324 [details] Patch
Lucas, when this lands can you please update build.webkit.org ?
Comment on attachment 352324 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=352324&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:332 > + "additionalArguments": ["--no-experimental-features --no-media-source"], Actually pretty sure this should be: ["--no-experimental-features", "--no-media-source"] right? That matches the rest of this file.
Yes! Thanks for the review!
Committed r237113: <https://trac.webkit.org/changeset/237113>
<rdar://problem/45272072>
(In reply to Philippe Normand from comment #2) > Lucas, when this lands can you please update build.webkit.org ? I just updated build.webkit.org for another change, so this should be live now.
Because of this change an additional buildbot step 'jhbuild' is being run. e.g.: notice 'jhbuild' step in: https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20Debian%20Stable%20%28Build%29/builds/18912 This is because https://trac.webkit.org/browser/webkit/trunk/Tools/BuildSlaveSupport/build.webkit.org-config/factories.py#L42 checks for "additionalArguments != ["--no-experimental-features"]" This causes unit-test failures: https://bugs.webkit.org/show_bug.cgi?id=193669 Is this step 'jhbuild' expected? If this step is expected, we should simply update unit-tests. If this step is not expected, factories.py L42 should be changed to something like: if platform == "gtk" and "--no-experimental-features" not in additionalArguments:
(In reply to Aakash Jain from comment #8) > Because of this change an additional buildbot step 'jhbuild' is being run. > e.g.: notice 'jhbuild' step in: > https://build.webkit.org/builders/GTK%20Linux%2064- > bit%20Release%20Debian%20Stable%20%28Build%29/builds/18912 > > > This is because > https://trac.webkit.org/browser/webkit/trunk/Tools/BuildSlaveSupport/build. > webkit.org-config/factories.py#L42 checks for "additionalArguments != > ["--no-experimental-features"]" > > This causes unit-test failures: > https://bugs.webkit.org/show_bug.cgi?id=193669 > > Is this step 'jhbuild' expected? > Hum, I'm not sure this is expected. IIRC the Debian and Ubuntu LTS bots shouldn't rely in jhbuild.
Wow, thanks for noticing Aakash. Indeed, these bots should not be running jhbuild as that defeats the purpose of having the bots. (In reply to Aakash Jain from comment #8) > if platform == "gtk" and "--no-experimental-features" not in > additionalArguments: This sounds like the right solution.