Bug 190336 - [JSC][YARR] Support YarrJIT in sampling profiler
Summary: [JSC][YARR] Support YarrJIT in sampling profiler
Status: RESOLVED DUPLICATE of bug 201702
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
Depends on:
Reported: 2018-10-07 06:39 PDT by Yusuke Suzuki
Modified: 2021-07-16 18:20 PDT (History)
1 user (show)

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2018-10-07 06:39:41 PDT
Comment 1 Yusuke Suzuki 2018-10-07 09:24:03 PDT
When running uglify-js / coffeescript in web-tooling-benchmark, so much time is consumed in '#<nil>:None:<nil>'.

Sampling rate: 1000.000000 microseconds
Hottest bytecodes as <numSamples   'functionName#hash:JITType:bytecodeIndex'>
  2441    'Function#<nil>:None:<nil>'
   642    '#<nil>:None:<nil>'
   462    'stringify#<nil>:None:<nil>'
   188    'defaults#EZuPgj:FTL:755'
   174    'push#EmOCkn:FTL:58'
   155    'quote#A7WHiP:Baseline:62 <-- compareTo#EmCQ7y:FTL:174'
   112    'compareTo#EmCQ7y:FTL:192'
    98    'is_unicode_combining_mark#CdiBr0:Baseline:43 <-- is_identifier_char#BBa5RX:FTL:123'
    95    '#Am9gS7:Baseline:10 <-- doit#At6wj3:FTL:76'
    84    'OutputStream#D03V2N:FTL:1420'
    71    'push#EmOCkn:FTL:114'
    70    'push#EmOCkn:FTL:180'
    69    'pop#CxNXKP:Baseline:85 <-- #D43Ncu:FTL:218'
    64    '_visit#AK9Sj2:FTL:100'
    61    'indexOf#<nil>:None:<nil>'

This is actually YarrJIT RegExp execution. We would like to have more detailed results for this time, like, "What RegExp takes much time?".
Comment 2 Saam Barati 2018-10-09 12:50:31 PDT
That would be nice.

I thought the sampling profiler knows when it's in the YARR?
Comment 3 Yusuke Suzuki 2021-07-16 18:20:42 PDT

*** This bug has been marked as a duplicate of bug 201702 ***