RESOLVED FIXED 190200
-Wunused-variable in RenderLayer::updateScrollableAreaSet 
https://bugs.webkit.org/show_bug.cgi?id=190200
Summary -Wunused-variable in RenderLayer::updateScrollableAreaSet
Michael Catanzaro
Reported 2018-10-02 08:46:13 PDT
We have an unused variable in RenderLayer::updateScrollableAreaSet. I fixed it in r236719 but that broke a bunch of scrolling tests (bug #190197), so clearly I'm not competent enough to do this unreviewed. Let's try again.
Attachments
Patch (1.48 KB, patch)
2018-10-02 09:10 PDT, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
Patch (2.39 KB, patch)
2018-10-02 10:24 PDT, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
Patch (2.41 KB, patch)
2018-10-03 01:06 PDT, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2018-10-02 09:10:30 PDT
Created attachment 351394 [details] Patch
Alex Christensen
Comment 2 2018-10-02 10:02:20 PDT
Comment on attachment 351394 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=351394&action=review > Source/WebCore/rendering/RenderLayer.cpp:6369 > + // Silence -Wunused-variable. The UNUSED_PARAM macro would work here, but the naming would be > + // off as it's not a parameter. This comment seems excessively verbose. Why not just use UNUSED_PARAM like we do in many other places, or make an UNUSED_VARIABLE macro?
Michael Catanzaro
Comment 3 2018-10-02 10:20:51 PDT
My vote is to make UNUSED_VARIABLE() in Compiler.h
Michael Catanzaro
Comment 4 2018-10-02 10:24:31 PDT
Did not build this yet... let's see if it passes EWS.
Michael Catanzaro
Comment 5 2018-10-02 10:24:48 PDT
Created attachment 351413 [details] Patch
Michael Catanzaro
Comment 6 2018-10-03 00:56:53 PDT
(In reply to Michael Catanzaro from comment #4) > Did not build this yet... let's see if it passes EWS. Signs point to "no."
Michael Catanzaro
Comment 7 2018-10-03 01:06:59 PDT
Created attachment 351488 [details] Patch
Yusuke Suzuki
Comment 8 2018-10-03 03:37:46 PDT
Comment on attachment 351488 [details] Patch r=me
WebKit Commit Bot
Comment 9 2018-10-03 04:03:55 PDT
Comment on attachment 351488 [details] Patch Clearing flags on attachment: 351488 Committed r236790: <https://trac.webkit.org/changeset/236790>
WebKit Commit Bot
Comment 10 2018-10-03 04:03:57 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 11 2018-10-03 04:04:28 PDT
<rdar://problem/44969810>
Note You need to log in before you can comment on or make changes to this bug.