Bug 190197 - REGRESSION(r236719): this revision caused 39 layout test failures that tested for scrolling, a bug was also not present in the commit or change log. (Requested by Truitt on #webkit).
Summary: REGRESSION(r236719): this revision caused 39 layout test failures that tested...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: WebKit Commit Bot
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-02 07:04 PDT by WebKit Commit Bot
Modified: 2018-10-07 12:10 PDT (History)
5 users (show)

See Also:

Attachments
ROLLOUT of r236719 (1.99 KB, patch)
2018-10-02 07:04 PDT, WebKit Commit Bot 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Commit Bot 2018-10-02 07:04:10 PDT 
https://trac.webkit.org/changeset/236719 broke the build:
this revision caused 39 layout test failures that tested for scrolling, a bug was also not present in the commit or change log. (Requested by Truitt on #webkit).

This is an automatic bug report generated by webkitbot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests fail.
Comment 1 WebKit Commit Bot 2018-10-02 07:04:17 PDT 
Created attachment 351383 [details]
ROLLOUT of r236719

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 WebKit Commit Bot 2018-10-02 07:19:59 PDT 
Comment on attachment 351383 [details]
ROLLOUT of r236719

Clearing flags on attachment: 351383

Committed r236741: <https://trac.webkit.org/changeset/236741>
Comment 3 WebKit Commit Bot 2018-10-02 07:20:01 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2018-10-02 07:20:37 PDT 
<rdar://problem/44937228>
Comment 5 Michael Catanzaro 2018-10-02 08:22:58 PDT 
Ah, I see the problem: frameView.addScrollableArea and frameView.removeScrollableArea have side effects. Thanks for the speedy rollout.

Note that we don't require bugs for trivial build fixes (in this case, -Wunused-variable).
Comment 6 Alexey Proskuryakov 2018-10-06 10:24:02 PDT 
Correct, we don’t require a bug for every commit. Mentioning that in a rollback bug seems useful anyway:

1. Maybe there was a bug, just not mentioned in ChangeLog. Not knowing about it means that the person who rolled back the change could not reopen the original. 

2. It makes it more clear that some context could have been lost (maybe there was an IRC discussion that not everyone saw).
Comment 7 Michael Catanzaro 2018-10-07 12:10:19 PDT 
Fixed properly in bug #190200