Bug 190165 – Web Inspector: move frontend managers to a container object

• Status: NEW
• Component: Web Inspector

[Devin Rousso]

Instead of having each manager's instance be a camel-cased object on `WI`, we should have a container for all manager objects (e.g. `WI.Manager.Foo`).

[Blaze Burg]

(In reply to Devin Rousso from comment #0)
> Instead of having each manager's instance be a camel-cased object on `WI`,
> we should have a container for all manager objects (e.g. `WI.Manager.Foo`).

The direction I started on was WI.sharedApp.fooManager, but I ran out of time for refactoring. I suggest you hang the instances off of WI.sharedApp. Joe will probably need to adjust this soon anyway.

[Devin Rousso]

Created attachment 351450 [details]
Patch

[Devin Rousso]

Created attachment 351659 [details]
Patch

This is in no rush to land, but I think it might help Joe with some of his work

[Blaze Burg]

(In reply to Devin Rousso from comment #3)
> Created attachment 351659 [details]
> Patch
> 
> This is in no rush to land, but I think it might help Joe with some of his
> work

This seem to go further down the path of making everything a singleton, which I believe is not what we want.

[Devin Rousso]

(In reply to Brian Burg from comment #4)
> (In reply to Devin Rousso from comment #3)
> > Created attachment 351659 [details]
> > Patch
> > 
> > This is in no rush to land, but I think it might help Joe with some of his
> > work
> 
> This seem to go further down the path of making everything a singleton,
> which I believe is not what we want.
Actually, this is meant to "centralize" all the managers into a more obvious place.  Additionally, this will be used by some of the stuff Joe's working on and may make his work easier.

[Blaze Burg]

Comment on attachment 351659 [details]
Patch

Marking r- as this conflicts with Joe's rearchitecture patches. Let's revisit this when the relevant frontend changes are finished (in particular, fixing un-targeted agent accesses).