This manager is never used.
Created attachment 351308 [details] Patch
Comment on attachment 351308 [details] Patch r-, so that we can remove eslint.js as well. We strip it in optimized builds because we aren't using it, but lets just remove it at this point. It has probably gotten pretty stale in the years its been unused.
Created attachment 351311 [details] Patch
Comment on attachment 351311 [details] Patch You need to update: WebKit/InspectorGResources.cmake 11: ${CMAKE_SOURCE_DIR}/Source/WebInspectorUI/UserInterface/External/ESLint/*.js r=me
Also to ensure this directory gets removed: Source/WebInspectorUI/UserInterface/External/ESLint I think you will want to ensure you have the following in your git configuration: [svn] rmdir = true I'm not sure if commit-queue figures this out or not, or if it makes git patches differ, but generally this is needed if landing manually: https://git-scm.com/docs/git-svn#git-svn---rmdir
(In reply to Joseph Pecoraro from comment #5) > Also to ensure this directory gets removed: > > Source/WebInspectorUI/UserInterface/External/ESLint > > I think you will want to ensure you have the following in your git > configuration: > > [svn] > rmdir = true > > I'm not sure if commit-queue figures this out or not, or if it makes git > patches differ, but generally this is needed if landing manually: > https://git-scm.com/docs/git-svn#git-svn---rmdir Nice tip! I was not aware of this.
Created attachment 351333 [details] Patch
Comment on attachment 351333 [details] Patch Clearing flags on attachment: 351333 Committed r236709: <https://trac.webkit.org/changeset/236709>
All reviewed patches have been landed. Closing bug.
<rdar://problem/44929189>