Bug 190162 - Web Inspector: remove analyzer manager
Summary: Web Inspector: remove analyzer manager
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks: 190165
  Show dependency treegraph
 
Reported: 2018-10-01 14:26 PDT by Devin Rousso
Modified: 2018-10-01 19:28 PDT (History)
5 users (show)

See Also:


Attachments
Patch (9.99 KB, patch)
2018-10-01 14:51 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff
Patch (620.71 KB, patch)
2018-10-01 15:01 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff
Patch (622.24 KB, patch)
2018-10-01 18:31 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2018-10-01 14:26:46 PDT
This manager is never used.
Comment 1 Devin Rousso 2018-10-01 14:51:55 PDT
Created attachment 351308 [details]
Patch
Comment 2 Joseph Pecoraro 2018-10-01 15:00:29 PDT
Comment on attachment 351308 [details]
Patch

r-, so that we can remove eslint.js as well. We strip it in optimized builds because we aren't using it, but lets just remove it at this point. It has probably gotten pretty stale in the years its been unused.
Comment 3 Devin Rousso 2018-10-01 15:01:59 PDT
Created attachment 351311 [details]
Patch
Comment 4 Joseph Pecoraro 2018-10-01 15:08:47 PDT
Comment on attachment 351311 [details]
Patch

You need to update:

    WebKit/InspectorGResources.cmake
    11:        ${CMAKE_SOURCE_DIR}/Source/WebInspectorUI/UserInterface/External/ESLint/*.js

r=me
Comment 5 Joseph Pecoraro 2018-10-01 15:11:42 PDT
Also to ensure this directory gets removed:

    Source/WebInspectorUI/UserInterface/External/ESLint

I think you will want to ensure you have the following in your git configuration:

    [svn]
	rmdir = true

I'm not sure if commit-queue figures this out or not, or if it makes git patches differ, but generally this is needed if landing manually:
https://git-scm.com/docs/git-svn#git-svn---rmdir
Comment 6 Matt Baker 2018-10-01 15:50:14 PDT
(In reply to Joseph Pecoraro from comment #5)
> Also to ensure this directory gets removed:
> 
>     Source/WebInspectorUI/UserInterface/External/ESLint
> 
> I think you will want to ensure you have the following in your git
> configuration:
> 
>     [svn]
> 	rmdir = true
> 
> I'm not sure if commit-queue figures this out or not, or if it makes git
> patches differ, but generally this is needed if landing manually:
> https://git-scm.com/docs/git-svn#git-svn---rmdir

Nice tip! I was not aware of this.
Comment 7 Devin Rousso 2018-10-01 18:31:43 PDT
Created attachment 351333 [details]
Patch
Comment 8 WebKit Commit Bot 2018-10-01 19:27:23 PDT
Comment on attachment 351333 [details]
Patch

Clearing flags on attachment: 351333

Committed r236709: <https://trac.webkit.org/changeset/236709>
Comment 9 WebKit Commit Bot 2018-10-01 19:27:25 PDT
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2018-10-01 19:28:23 PDT
<rdar://problem/44929189>