Bug 190150 - [Win][DRT] Actually set "experimental:WebAnimationsCSSIntegrationEnabled" when requested
Summary: [Win][DRT] Actually set "experimental:WebAnimationsCSSIntegrationEnabled" whe...
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ross Kirsling
Keywords: InRadar
Depends on:
Blocks: 190032
  Show dependency treegraph
Reported: 2018-10-01 11:40 PDT by Ross Kirsling
Modified: 2018-10-01 22:25 PDT (History)
8 users (show)

See Also:

Patch (1.57 KB, patch)
2018-10-01 11:42 PDT, Ross Kirsling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ross Kirsling 2018-10-01 11:40:48 PDT
[Win][DRT] Actually set "experimental:WebAnimationsCSSIntegrationEnabled" when requested
Comment 1 Ross Kirsling 2018-10-01 11:42:03 PDT
Created attachment 351280 [details]
Comment 2 Fujii Hironori 2018-10-01 18:04:52 PDT
Mac port DRT has more options. Don't you need them?
Comment 3 Ross Kirsling 2018-10-01 19:38:44 PDT
(In reply to Fujii Hironori from comment #2)
> Mac port DRT has more options. Don't you need them?
> https://github.com/WebKit/webkit/blob/
> 234976b18c6973855fa27c50eea2070878ea1488/Tools/DumpRenderTree/mac/
> DumpRenderTree.mm#L998

Hmm, it would certainly seem like it, but evidently none of the other options currently have setters available in IWebPreferencesPrivate.idl:

So I suppose it'd be better to add them in the future, if we ever end up needing them in WKL.
Comment 4 WebKit Commit Bot 2018-10-01 22:24:51 PDT
Comment on attachment 351280 [details]

Clearing flags on attachment: 351280

Committed r236712: <https://trac.webkit.org/changeset/236712>
Comment 5 WebKit Commit Bot 2018-10-01 22:24:53 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-10-01 22:25:25 PDT