Bug 190032 – [Web Animations] Fix test regressions after enabling Web Animations with CSS Integration

• Status: REOPENED
• Component: Animations

[Antoine Quint]

This bug tracks the followup work required after landing the fix for https://bugs.webkit.org/show_bug.cgi?id=184819.

[Radar WebKit Bug Importer]

<rdar://problem/44824973>

[Truitt Savell]

These three tests are crashing after https://trac.webkit.org/changeset/236541/webkit

legacy-animation-engine/transitions/transition-to-from-auto.html 
legacy-animation-engine/transitions/extra-transition.html 
legacy-animation-engine/animations/duplicate-keys.html

History:
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=legacy-animation-engine%2Ftransitions%2Ftransition-to-from-auto.html%20legacy-animation-engine%2Ftransitions%2Fextra-transition.html%20legacy-animation-engine%2Fanimations%2Fduplicate-keys.html

Crashes are occurring on Mac Debug WK1

[Antoine Quint]

Individually none of those tests crash on WK1 Debug locally. However, the crash reported on the bots is webkit.org/b/186946.

[Ross Kirsling]

WinCairo has 85 diff failures (actually including the output "FAIL") under legacy-animation-engine as a result of the patch:
https://build.webkit.org/results/WinCairo%2064-bit%20WKL%20Release%20(Tests)/r236582%20(1722)/results.html

[Antoine Quint]

(In reply to Truitt Savell from comment #2)
> These three tests are crashing after
> https://trac.webkit.org/changeset/236541/webkit
> 
> legacy-animation-engine/transitions/transition-to-from-auto.html 
> legacy-animation-engine/transitions/extra-transition.html 
> legacy-animation-engine/animations/duplicate-keys.html

These should no longer be happening as of https://trac.webkit.org/changeset/236650.

[Ross Kirsling]

The WinCairo failures are due to a trivial oversight that evidently didn't matter until now -- patch submitted in bug 190150.

[Truitt Savell]

animations/missing-values-first-keyframe.html
animations/missing-values-last-keyframe.html

these two tests appear to be passing everywhere. Removed their expectation in https://trac.webkit.org/changeset/263421/webkit

[Antoine Quint]

I don't think this is tracking any actual work anymore, let's close this.

[Fujii Hironori]

This bug ID is still used to mark failing tests in TestExpectations. Reopened.
https://github.com/WebKit/WebKit/blob/aaa1eb722ad16c0a03c7d09924b8e6611fb65acb/LayoutTests/TestExpectations#L3520-L3527