Bug 190032 - [Web Animations] Fix test regressions after enabling Web Animations with CSS Integration
Summary: [Web Animations] Fix test regressions after enabling Web Animations with CSS ...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on: 190150
Blocks:
  Show dependency treegraph
 
Reported: 2018-09-27 02:34 PDT by Antoine Quint
Modified: 2022-02-16 15:14 PST (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2018-09-27 02:34:17 PDT
This bug tracks the followup work required after landing the fix for https://bugs.webkit.org/show_bug.cgi?id=184819.
Comment 1 Radar WebKit Bug Importer 2018-09-27 02:34:48 PDT
<rdar://problem/44824973>
Comment 2 Truitt Savell 2018-09-27 13:27:19 PDT
These three tests are crashing after https://trac.webkit.org/changeset/236541/webkit

legacy-animation-engine/transitions/transition-to-from-auto.html 
legacy-animation-engine/transitions/extra-transition.html 
legacy-animation-engine/animations/duplicate-keys.html

History:
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=legacy-animation-engine%2Ftransitions%2Ftransition-to-from-auto.html%20legacy-animation-engine%2Ftransitions%2Fextra-transition.html%20legacy-animation-engine%2Fanimations%2Fduplicate-keys.html

Crashes are occurring on Mac Debug WK1
Comment 3 Antoine Quint 2018-09-28 06:05:26 PDT
Individually none of those tests crash on WK1 Debug locally. However, the crash reported on the bots is webkit.org/b/186946.
Comment 4 Ross Kirsling 2018-09-28 14:48:56 PDT
WinCairo has 85 diff failures (actually including the output "FAIL") under legacy-animation-engine as a result of the patch:
https://build.webkit.org/results/WinCairo%2064-bit%20WKL%20Release%20(Tests)/r236582%20(1722)/results.html
Comment 5 Antoine Quint 2018-10-01 01:05:51 PDT
(In reply to Truitt Savell from comment #2)
> These three tests are crashing after
> https://trac.webkit.org/changeset/236541/webkit
> 
> legacy-animation-engine/transitions/transition-to-from-auto.html 
> legacy-animation-engine/transitions/extra-transition.html 
> legacy-animation-engine/animations/duplicate-keys.html

These should no longer be happening as of https://trac.webkit.org/changeset/236650.
Comment 6 Ross Kirsling 2018-10-01 11:44:56 PDT
The WinCairo failures are due to a trivial oversight that evidently didn't matter until now -- patch submitted in bug 190150.
Comment 7 Truitt Savell 2020-06-23 14:40:04 PDT
animations/missing-values-first-keyframe.html
animations/missing-values-last-keyframe.html

these two tests appear to be passing everywhere. Removed their expectation in https://trac.webkit.org/changeset/263421/webkit