Bug 190097 - Skip debug assertion in ResourceLoadStatisticsMemoryStore::recursivelyGetAllDomainsThatHaveRedirectedToThisDomain()
Summary: Skip debug assertion in ResourceLoadStatisticsMemoryStore::recursivelyGetAllD...
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: John Wilander
Keywords: InRadar
Depends on:
Reported: 2018-09-28 15:35 PDT by John Wilander
Modified: 2018-09-28 18:36 PDT (History)
3 users (show)

See Also:

Patch (2.28 KB, patch)
2018-09-28 15:40 PDT, John Wilander
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Wilander 2018-09-28 15:35:40 PDT
The change in https://bugs.webkit.org/show_bug.cgi?id=190055 causes a re-classification that may trigger a debug assertion in ResourceLoadStatisticsMemoryStore::recursivelyGetAllDomainsThatHaveRedirectedToThisDomain(). We should skip the assertion for statistics model version 14.
Comment 1 Radar WebKit Bug Importer 2018-09-28 15:36:14 PDT
Comment 2 John Wilander 2018-09-28 15:40:26 PDT
Created attachment 351127 [details]
Comment 3 John Wilander 2018-09-28 18:11:06 PDT
Comment on attachment 351127 [details]

Thanks, Chris! The iOS-sim bot seems to have unrelated issues.
Comment 4 WebKit Commit Bot 2018-09-28 18:36:34 PDT
Comment on attachment 351127 [details]

Clearing flags on attachment: 351127

Committed r236630: <https://trac.webkit.org/changeset/236630>
Comment 5 WebKit Commit Bot 2018-09-28 18:36:35 PDT
All reviewed patches have been landed.  Closing bug.