Bug 190055 – Resource Load Statistics: Non-redirected top frame navigation should not get captured in statistics

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[John Wilander]

We should skip statistics collection of regular top frame navigational redirects.

[John Wilander]

Sorry, we should skip statistics collection of regular top frame navigational loads. Redirects should still be captured.

[Radar WebKit Bug Importer]

<rdar://problem/44843460>

[John Wilander]

Created attachment 351002 [details]
Patch

[Chris Dumez]

Comment on attachment 351002 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351002&action=review

> LayoutTests/http/tests/resourceLoadStatistics/do-not-capture-statistics-for-simple-top-navigations-expected.txt:4
> +PASS testRunner.isStatisticsRegisteredAsSubFrameUnder("http://localhost", "http://127.0.0.1") is false

Having PASS lines *after* the "TEST COMPLETE" line indicates the test is written wrong and that it will likely be flaky.

> LayoutTests/http/tests/resourceLoadStatistics/do-not-capture-statistics-for-simple-top-navigations.html:5
> +    <title>Test that a non-redirected top frame navigation doesn't get captured in statistics</title>

Would be nice to use description("Test that a non-redirected top frame navigation doesn't get captured in statistics"); instead of that it shows in the output.

> LayoutTests/http/tests/resourceLoadStatistics/do-not-capture-statistics-for-simple-top-navigations.html:15
> +            testRunner.notifyDone();

Should be:
finishJSTest();

> LayoutTests/http/tests/resourceLoadStatistics/do-not-capture-statistics-for-simple-top-navigations.html:23
> +                    testRunner.waitUntilDone();

Please use:
jsTestIsAsync = true;

right after the description();

[John Wilander]

Created attachment 351005 [details]
Patch

[Chris Dumez]

Comment on attachment 351005 [details]
Patch

r=me if the bots are happy.

[John Wilander]

Thank you, Chris!

[WebKit Commit Bot]

Comment on attachment 351005 [details]
Patch

Clearing flags on attachment: 351005

Committed r236578: <https://trac.webkit.org/changeset/236578>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[John Wilander]

Follow-up change tracked in https://bugs.webkit.org/show_bug.cgi?id=190097.