ASSIGNED 190023
Considering making Options::useSeparatedWXHeap() always false if ENABLE(FAST_JIT_PERMISSIONS). 
https://bugs.webkit.org/show_bug.cgi?id=190023
Summary Considering making Options::useSeparatedWXHeap() always false if ENABLE(FAST_...
Mark Lam
Reported 2018-09-26 18:16:15 PDT
In https://bugs.webkit.org/show_bug.cgi?id=190022, we disable Options::useSeparatedWXHeap() if ENABLE(FAST_JIT_PERMISSIONS) && CPU(ARM64E). However, I think we can disable if Options::useSeparatedWXHeap() if we have ENABLE(FAST_JIT_PERMISSIONS). It doesn't have to be CPU(ARM64E). Consider making this so.
Attachments
Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2018-09-27 10:17:51 PDT
See https://bugs.webkit.org/show_bug.cgi?id=190022#c3: Also consider introducing a new ENABLE macro specifically for SeparatedWXHeap, an ENABLE_SEPARATED_WXHEAP for the purpose of making the code more readable.
Note You need to log in before you can comment on or make changes to this bug.