Bug 190023 - Considering making Options::useSeparatedWXHeap() always false if ENABLE(FAST_JIT_PERMISSIONS).
Summary: Considering making Options::useSeparatedWXHeap() always false if ENABLE(FAST_...
Status: ASSIGNED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on: 190022
Blocks:
  Show dependency tree / graph
 
Reported: 2018-09-26 18:16 PDT by Mark Lam
Modified: 2018-09-27 10:17 PDT (History)
7 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2018-09-26 18:16:15 PDT 
In https://bugs.webkit.org/show_bug.cgi?id=190022, we disable Options::useSeparatedWXHeap() if ENABLE(FAST_JIT_PERMISSIONS) && CPU(ARM64E).  However, I think we can disable if 
Options::useSeparatedWXHeap() if we have ENABLE(FAST_JIT_PERMISSIONS).  It doesn't have to be CPU(ARM64E).  Consider making this so.
Comment 1 Mark Lam 2018-09-27 10:17:51 PDT 
See https://bugs.webkit.org/show_bug.cgi?id=190022#c3:
Also consider introducing a new ENABLE macro specifically for SeparatedWXHeap, an ENABLE_SEPARATED_WXHEAP for the purpose of making the code more readable.