Bug 190022 - Options::useSeparatedWXHeap() should always be false when ENABLE(FAST_JIT_PERMISSIONS) && CPU(ARM64E).
Summary: Options::useSeparatedWXHeap() should always be false when ENABLE(FAST_JIT_PER...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks: 190023
  Show dependency tree / graph
 
Reported: 2018-09-26 18:12 PDT by Mark Lam
Modified: 2018-09-27 10:14 PDT (History)
8 users (show)

See Also:

Attachments
proposed patch. (5.73 KB, patch)
2018-09-26 18:24 PDT, Mark Lam 		saam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2018-09-26 18:12:25 PDT 
<rdar://problem/44800928>
Comment 1 Mark Lam 2018-09-26 18:24:40 PDT 
Created attachment 350933 [details]
proposed patch.
Comment 2 Mark Lam 2018-09-26 21:37:09 PDT 
Thanks for the review.  Landed in r236538: <http://trac.webkit.org/r236538>.
Comment 3 Sam Weinig 2018-09-27 10:14:27 PDT 
Comment on attachment 350933 [details]
proposed patch.

I think this might be a little more clear if you introduced a new ENABLE macro specifically for SeparatedWXHeap, an ENABLE_ SEPARATED_WXHEAP.