Bug 189993 - REGRESSION(r236365): [GTK] Many form-related tests are failing
Summary: REGRESSION(r236365): [GTK] Many form-related tests are failing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 191361 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-09-26 07:35 PDT by Alicia Boya García
Modified: 2018-11-09 08:15 PST (History)
9 users (show)

See Also:

Attachments
Patch (3.28 KB, patch)
2018-11-09 06:24 PST, Carlos Garcia Campos 		mcatanzaro: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alicia Boya García 2018-09-26 07:35:24 PDT 
The following tests are failing on GTK since r236365-236372:

http/tests/fileapi/xhr-send-form-data-filename-escaping.html
http/tests/fileapi/xhr-send-form-data-mimetype-normalization.html
http/tests/local/formdata/send-form-data-constructed-from-form-using-open-panel.html
http/tests/misc/form-blob-challenge.html
Comment 1 Ms2ger (he/him; ⌚ UTC+1/+2) 2018-09-26 07:45:03 PDT 
Bug 189777 / r236365 looks highly suspicious.
Comment 2 Alicia Boya García 2018-09-26 08:38:18 PDT 
I git bisect'ed the failures to r236365. https://bugs.webkit.org/show_bug.cgi?id=189777
Comment 3 Carlos Garcia Campos 2018-11-09 06:24:29 PST 
Created attachment 354334 [details]
Patch
Comment 4 Carlos Garcia Campos 2018-11-09 06:24:59 PST 
*** Bug 191361 has been marked as a duplicate of this bug. ***
Comment 5 Michael Catanzaro 2018-11-09 07:04:25 PST 
Comment on attachment 354334 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354334&action=review

> Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp:77
> -        return switchOn(element.data,
> +        switchOn(element.data,

It's a shame the compiler didn't warn about this, actually. I guess because switchOn returns void, it figures the return type of the function matches... but still, nobody would write this intentionally. :(
Comment 6 Carlos Garcia Campos 2018-11-09 08:15:13 PST 
Committed r238030: <https://trac.webkit.org/changeset/238030>