Use a Variant for FormDataElement
Created attachment 350169 [details] Patch
Comment on attachment 350169 [details] Patch Attachment 350169 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/9277810 Number of test failures exceeded the failure limit.
Created attachment 350171 [details] Archive of layout-test-results from ews102 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 350169 [details] Patch Attachment 350169 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9277821 Number of test failures exceeded the failure limit.
Created attachment 350173 [details] Archive of layout-test-results from ews106 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 350169 [details] Patch Attachment 350169 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/9277814 Number of test failures exceeded the failure limit.
Created attachment 350176 [details] Archive of layout-test-results from ews117 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 350169 [details] Patch Attachment 350169 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9277857 Number of test failures exceeded the failure limit.
Created attachment 350177 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Created attachment 350240 [details] Patch
Created attachment 350245 [details] Patch
Created attachment 350246 [details] Patch
Created attachment 350249 [details] Patch
Created attachment 350260 [details] Patch
Created attachment 350270 [details] Patch
Created attachment 350285 [details] Patch
Created attachment 350299 [details] Patch
Comment on attachment 350299 [details] Patch Attachment 350299 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9290636 New failing tests: http/tests/local/formdata/send-form-data-constructed-from-form-using-open-panel.html http/tests/local/formdata/send-form-data-with-empty-file-filename-using-open-panel.html
Created attachment 350318 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 350299 [details] Patch Attachment 350299 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9291283 New failing tests: http/tests/local/formdata/send-form-data-constructed-from-form-using-open-panel.html http/tests/local/formdata/send-form-data-with-empty-file-filename-using-open-panel.html
Created attachment 350324 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 350299 [details] Patch Attachment 350299 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9291812 New failing tests: http/tests/local/formdata/send-form-data-constructed-from-form-using-open-panel.html http/tests/local/formdata/send-form-data-with-empty-file-filename-using-open-panel.html
Created attachment 350330 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Created attachment 350335 [details] Patch
Comment on attachment 350335 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=350335&action=review r=me > Source/WebCore/platform/network/FormData.cpp:142 > + return WTF::visit(WTF::makeVisitor( SwitchOn() ? > Source/WebCore/platform/network/FormData.cpp:160 > + return WTF::visit(WTF::makeVisitor( SwitchOn() ? > Source/WebCore/platform/network/FormData.cpp:358 > + WTF::visit(WTF::makeVisitor( SwitchOn() ? > Source/WebCore/platform/network/FormData.h:44 > + FormDataElement(Data&& data) Why isn't this explicit ? > Source/WebCore/platform/network/FormData.h:75 > + bool shouldGenerateFile { false }; Can we pack this better and move all booleans to the end? > Source/WebCore/platform/network/cf/FormDataStreamCFNet.cpp:139 > + bool success = WTF::visit(WTF::makeVisitor( SwitchOn() ? > Source/WebCore/platform/network/curl/CurlFormDataStream.cpp:127 > + std::optional<size_t> readBytes = WTF::visit(WTF::makeVisitor( SwitchOn() ? > Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp:77 > + return WTF::visit(WTF::makeVisitor( SwitchOn() ? > Source/WebKit/WebProcess/WebCoreSupport/SessionStateConversion.cpp:45 > + WTF::visit(WTF::makeVisitor( SwitchOn() ?
Created attachment 350428 [details] Patch
Created attachment 350430 [details] Patch
http://trac.webkit.org/r236365
<rdar://problem/44695354>