Bug 189961 - [WPE][GTK] Fix HTTP credentials in sandbox
Summary: [WPE][GTK] Fix HTTP credentials in sandbox
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 189956
  Show dependency treegraph
 
Reported: 2018-09-25 11:31 PDT by Patrick Griffis
Modified: 2018-10-15 08:11 PDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Griffis 2018-09-25 11:31:31 PDT
Currently the WebProcess talks to libsecret for HTTP credentials.

This is unacceptable and needs to be proxied through the UI layer which can
limit password access by origin.

See also how this was handled in Epiphany: https://gitlab.gnome.org/GNOME/epiphany/commit/68b0f85747a177047a7b49d839895aad54b05309
Comment 1 Michael Catanzaro 2018-09-28 08:32:00 PDT
As part of this I want to rework how credentials are saved. Give the application a signal so it can save credentials in its own way. E.g. Epiphany should be able to put WebKitGTK+ passwords with all the user's Epiphany passwords. It doesn't make sense that just the few HTTP auth passwords are separated.
Comment 2 Patrick Griffis 2018-10-15 08:11:00 PDT
We've decided to trust the NetworkProcess for now and not sandbox it so this no longer applies.