Bug 189883 - Native functions which accept pointers need to do null checks
Summary: Native functions which accept pointers need to do null checks
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks: 176199 189202
  Show dependency treegraph
 
Reported: 2018-09-22 03:28 PDT by Myles C. Maxfield
Modified: 2018-10-13 14:52 PDT (History)
6 users (show)

See Also:


Attachments
Patch (26.86 KB, patch)
2018-09-22 15:56 PDT, Myles C. Maxfield
dino: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2018-09-22 03:28:24 PDT
WHLSL functions automatically do null checks, but the native functions don't.
Comment 1 Myles C. Maxfield 2018-09-22 15:56:35 PDT
Created attachment 350536 [details]
Patch
Comment 2 Myles C. Maxfield 2018-09-22 16:34:57 PDT
Committed r236388: <https://trac.webkit.org/changeset/236388>
Comment 3 Radar WebKit Bug Importer 2018-09-22 16:35:19 PDT
<rdar://problem/44708648>
Comment 4 Myles C. Maxfield 2018-10-13 14:23:16 PDT
Migrated to https://api.github.com/repos/gpuweb/WHLSL/issues/29
Comment 5 Myles C. Maxfield 2018-10-13 14:52:50 PDT
https://github.com/gpuweb/WHLSL/issues/29