Bug 189867 - Add PointerEvent, plus feature flag, plus Web Platform Tests
Summary: Add PointerEvent, plus feature flag, plus Web Platform Tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-09-21 16:47 PDT by Dean Jackson
Modified: 2018-09-22 16:38 PDT (History)
9 users (show)

See Also:

Attachments
Patch (112.13 KB, patch)
2018-09-21 16:59 PDT, Dean Jackson 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2018-09-21 16:47:38 PDT 
Add PointerEvent, plus feature flag, plus Web Platform Tests
Comment 1 Radar WebKit Bug Importer 2018-09-21 16:48:20 PDT 
<rdar://problem/44697384>
Comment 2 Dean Jackson 2018-09-21 16:59:21 PDT 
Created attachment 350457 [details]
Patch
Comment 3 Simon Fraser (smfr) 2018-09-21 17:35:51 PDT 
Comment on attachment 350457 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350457&action=review

Please also add to features.json

> Source/WebCore/dom/PointerEvent.cpp:35
> +PointerEvent::PointerEvent()
> +{
> +}

Remove or use = default

> Source/WebCore/dom/PointerEvent.cpp:48
> +    , m_pointerId(WTFMove(initializer.pointerId))
> +    , m_width(WTFMove(initializer.width))
> +    , m_height(WTFMove(initializer.height))
> +    , m_pressure(WTFMove(initializer.pressure))
> +    , m_tangentialPressure(WTFMove(initializer.tangentialPressure))
> +    , m_tiltX(WTFMove(initializer.tiltX))
> +    , m_tiltY(WTFMove(initializer.tiltY))
> +    , m_twist(WTFMove(initializer.twist))
> +    , m_pointerType(WTFMove(initializer.pointerType))
> +    , m_isPrimary(WTFMove(initializer.isPrimary))

No need to WTFMove POD

> Source/WebCore/page/RuntimeEnabledFeatures.h:340
> +    bool m_areWebAnimationsEnabled { true };
> +    bool m_isWebAnimationsCSSIntegrationEnabled { false };
> +    bool m_isImageBitmapOffscreenCanvasEnabled { true };
> +    bool m_isCacheAPIEnabled { false };
> +    bool m_isFetchAPIEnabled { true };
> +    bool m_isWebSocketEnabled { true };
> +    bool m_fetchAPIKeepAliveEnabled { false };
> +    bool m_inspectorAdditionsEnabled { false };
> +    bool m_webVREnabled { false };
> +    bool m_accessibilityObjectModelEnabled { false };
> +    bool m_ariaReflectionEnabled { true };
> +    bool m_resourceLoadStatisticsDebugMode { false };
> +    bool m_isRestrictedHTTPResponseAccess { true };
> +    bool m_crossOriginResourcePolicyEnabled { true };
> +    bool m_isWebGLCompressedTextureASTCSupportEnabled { false };
> +    bool m_promptForStorageAccessAPIEnabled { false };
> +    bool m_isServerTimingEnabled { false };
> +    bool m_experimentalPlugInSandboxProfilesEnabled { false };
> +    bool m_disabledAdaptationsMetaTagEnabled { false };
> +    bool m_attrStyleEnabled { false };
> +    bool m_webAPIStatisticsEnabled { false };
> +    bool m_CSSCustomPropertiesAndValuesEnabled { false };
> +    bool m_pointerEventsEnabled { false };

Please sort.
Comment 4 Dean Jackson 2018-09-21 17:52:09 PDT 
Committed r236378: <https://trac.webkit.org/changeset/236378>
Comment 5 David Tapuska 2018-09-21 18:13:31 PDT 
Will https://bugs.webkit.org/show_bug.cgi?id=133112 be fixed too?
Comment 6 Dean Jackson 2018-09-22 15:23:44 PDT 
(In reply to David Tapuska from comment #5)
> Will https://bugs.webkit.org/show_bug.cgi?id=133112 be fixed too?

Yes
Comment 7 David Tapuska 2018-09-22 16:38:26 PDT 
Whoot! Great work.. looking forward to testing for interop.