Bug 189864 - Web Inspector: REGRESSION(r236336): computed CSSProperty doesn't have a value for _text
Summary: Web Inspector: REGRESSION(r236336): computed CSSProperty doesn't have a value...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on: 189808
Blocks:
  Show dependency tree / graph
 
Reported: 2018-09-21 15:44 PDT by Devin Rousso
Modified: 2018-09-21 19:04 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.04 KB, patch)
2018-09-21 15:47 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2018-09-21 15:44:41 PDT 
`CSS.types.CSSComputedStyleProperty` doesn't include a `text` value, which was used by "inspector/css/pseudo-element-matches-for-pseudo-element-node.html" for printing the property's text.  Modify the test to generate it's own text result via `name` and `value`.
Comment 1 Devin Rousso 2018-09-21 15:47:16 PDT 
Created attachment 350447 [details]
Patch
Comment 2 Joseph Pecoraro 2018-09-21 17:02:35 PDT 
Comment on attachment 350447 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2018-09-21 19:03:59 PDT 
Comment on attachment 350447 [details]
Patch

Clearing flags on attachment: 350447

Committed r236380: <https://trac.webkit.org/changeset/236380>
Comment 4 WebKit Commit Bot 2018-09-21 19:04:01 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-09-21 19:04:22 PDT 
<rdar://problem/44699783>