Bug 189808 – Web Inspector: remove Legacy Style Editor

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

The Legacy Style Editor has been hidden behind an "experimental" setting for almost a year.  It's time that we remove it, especially since the new Style Editor is at a similar, if not more advanced, state.

[Devin Rousso]

Created attachment 350308 [details]
Patch

[EWS Watchlist]

Comment on attachment 350308 [details]
Patch

Attachment 350308 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/9290858

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 350313 [details]
Archive of layout-test-results from ews102 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-sierra  Platform: Mac OS X 10.12.6

[Devin Rousso]

Created attachment 350323 [details]
Patch

Forgot to upload my changes to what files are included

[EWS Watchlist]

Comment on attachment 350323 [details]
Patch

Attachment 350323 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/9291986

New failing tests:
inspector/css/generate-css-rule-string.html
inspector/css/css-property.html
inspector/css/shadow-scoped-style.html
inspector/css/modify-css-property.html
inspector/unit-tests/test-harness-expect-functions.html

[EWS Watchlist]

Created attachment 350329 [details]
Archive of layout-test-results from ews103 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 350323 [details]
Patch

Attachment 350323 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/9292238

New failing tests:
inspector/css/generate-css-rule-string.html
inspector/css/css-property.html
inspector/css/shadow-scoped-style.html
inspector/css/modify-css-property.html
inspector/unit-tests/test-harness-expect-functions.html

[EWS Watchlist]

Created attachment 350332 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[Devin Rousso]

Created attachment 350333 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 350333 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350333&action=review

r=me. Awesome, this looks like a pretty thorough removal!

> Source/WebInspectorUI/ChangeLog:16
> +        * Tools/PrettyPrinting/index.html:

Nice!

> Source/WebInspectorUI/ChangeLog:104
> +        * UserInterface/Views/CodeMirrorFormatters.js:
> +        Remove "css-rule" CodeMirror mode.

The CodeMirror "javascript" formatter in here can actually be removed as well. I always thought we might use it for smaller chunks of things but it looks like it is unreachable now. We can remove that in a separate patch.

> LayoutTests/inspector/css/css-property.html:190
> -                        InspectorTest.expectEqual(property.text, "background-repeat-y: repeat;", `"${property.name}" has the text "background-repeat-y: repeat;".`);
> +                        InspectorTest.expectEqual(property.text, "", `"${property.name}" has the text "".`);

This seems different.

[Devin Rousso]

Comment on attachment 350333 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350333&action=review

>> LayoutTests/inspector/css/css-property.html:190
>> +                        InspectorTest.expectEqual(property.text, "", `"${property.name}" has the text "".`);
> 
> This seems different.

This is explained in a comment on line 175-178 of this file.  `CSSProperty.prototype.synthesizedText` was removed, so we no longer synthesize a value.

The reason that `background-repeat-x` still has a value is because it is explicitly defined in the `<style>` on line 254 of this file.

[WebKit Commit Bot]

Comment on attachment 350333 [details]
Patch

Clearing flags on attachment: 350333

Committed r236336: <https://trac.webkit.org/changeset/236336>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/44686735>

[Truitt Savell]

Looks like https://trac.webkit.org/changeset/236336/webkit

Has caused inspector/css/pseudo-element-matches-for-pseudo-element-node.html to fail continuously on Mac Release 

history:
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Fcss%2Fpseudo-element-matches-for-pseudo-element-node.html

Diff:
--- /Volumes/Data/slave/highsierra-release-tests-wk1/build/layout-test-results/inspector/css/pseudo-element-matches-for-pseudo-element-node-expected.txt
+++ /Volumes/Data/slave/highsierra-release-tests-wk1/build/layout-test-results/inspector/css/pseudo-element-matches-for-pseudo-element-node-actual.txt
@@ -9,8 +9,8 @@
 PASS: No Inherited Styles
 PASS: No Pseudo Element Styles
 PASS: Has Computed Styles
-PROPERTY: content: before;
-PROPERTY: color: rgb(0, 0, 255);
+PROPERTY: 
+PROPERTY: 
 MATCHED RULE:
   SELECTOR: input:before
   SELECTOR: #x:before [matched]