Convert op_to_this as a POC for https://bugs.webkit.org/show_bug.cgi?id=187373
Created attachment 350195 [details] Patch
Comment on attachment 350195 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=350195&action=review > Source/JavaScriptCore/bytecode/OpToThis.h:87 > + ASSERT(opcodeID == op_to_this); Make this ASSERT_UNUSED(opcodeID, opcodeID == op_to_this) to fix the release build failures.
Created attachment 350243 [details] Patch
Created attachment 350276 [details] Patch
Created attachment 350278 [details] Patch
Comment on attachment 350278 [details] Patch Attachment 350278 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/9288547 Number of test failures exceeded the failure limit.
Created attachment 350284 [details] Archive of layout-test-results from ews102 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6
Created attachment 350287 [details] Patch
Comment on attachment 350287 [details] Patch Attachment 350287 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/9289532 Number of test failures exceeded the failure limit.
Created attachment 350297 [details] Archive of layout-test-results from ews102 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 350287 [details] Patch Attachment 350287 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/9289433 Number of test failures exceeded the failure limit.
Created attachment 350300 [details] Archive of layout-test-results from ews112 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-sierra Platform: Mac OS X 10.12.6
Created attachment 350301 [details] Patch
Comment on attachment 350301 [details] Patch Attachment 350301 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/9290439 Number of test failures exceeded the failure limit.
Created attachment 350307 [details] Archive of layout-test-results from ews102 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 350301 [details] Patch Attachment 350301 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/9290613 Number of test failures exceeded the failure limit.
Created attachment 350312 [details] Archive of layout-test-results from ews115 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 350301 [details] Patch Attachment 350301 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9290680 Number of test failures exceeded the failure limit.
Created attachment 350316 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 350301 [details] Patch Attachment 350301 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9291472 Number of test failures exceeded the failure limit.
Created attachment 350325 [details] Archive of layout-test-results from ews104 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Created attachment 350414 [details] Patch
Comment on attachment 350414 [details] Patch Attachment 350414 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/9301919 Number of test failures exceeded the failure limit.
Created attachment 350432 [details] Archive of layout-test-results from ews102 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 350414 [details] Patch Attachment 350414 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/9301759 Number of test failures exceeded the failure limit.
Created attachment 350433 [details] Archive of layout-test-results from ews112 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 350414 [details] Patch Attachment 350414 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9302186 Number of test failures exceeded the failure limit.
Created attachment 350436 [details] Archive of layout-test-results from ews106 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Created attachment 350437 [details] Patch
Created attachment 350440 [details] Patch
Created attachment 350445 [details] Patch
Comment on attachment 350445 [details] Patch Attachment 350445 [details] did not pass jsc-ews (mac): Output: https://webkit-queues.webkit.org/results/9304234 New failing tests: v8-v6/v8-deltablue.js.ftl-eager-no-cjit wasm.yaml/wasm/js-api/extension-MemoryMode.js.wasm-no-call-ic microbenchmarks/delta-blue-try-catch.js.ftl-eager-no-cjit stress/put-direct-index-broken-2.js.dfg-eager-no-cjit-validate v8-v6/v8-deltablue.js.dfg-eager stress/v8-deltablue-strict.js.ftl-eager-no-cjit microbenchmarks/deltablue-for-of.js.dfg-eager-no-cjit-validate stress/arrow-functions-as-default-parameter-values.js.no-cjit-collect-continuously microbenchmarks/deltablue-varargs.js.no-cjit-collect-continuously stress/arrowfunction-lexical-bind-superproperty.js.ftl-eager-no-cjit stress/parameter-scoping.js.dfg-eager v8-v6/v8-deltablue.js.ftl-eager stress/rest-parameter-is-destructuring.js.ftl-eager stress/super-property-access.js.no-cjit-collect-continuously stress/reflect-set.js.ftl-eager v8-v6/v8-crypto.js.ftl-eager stress/v8-deltablue-strict.js.dfg-eager-no-cjit-validate microbenchmarks/poly-proto-clear-js-function-allocation-profile.js.dfg-eager-no-cjit-validate stress/arrow-functions-as-default-parameter-values.js.dfg-eager-no-cjit-validate stress/put-by-val-slow-put-array-storage.js.dfg-eager-no-cjit-validate stress/dfg-put-setter-by-id-class.js.dfg-eager-no-cjit-validate stress/v8-deltablue-strict.js.no-cjit-collect-continuously v8-v6/v8-crypto.js.dfg-eager-no-cjit-validate stress/v8-deltablue-strict.js.ftl-eager stress/arrow-functions-as-default-parameter-values.js.ftl-eager-no-cjit stress/spread-calling.js.ftl-eager stress/put-by-val-slow-put-array-storage.js.ftl-eager-no-cjit microbenchmarks/delta-blue-try-catch.js.dfg-eager stress/ftl-put-by-id-setter-exception.js.ftl-eager stress/regress-153486.js.dfg-eager wasm.yaml/wasm/js-api/extension-MemoryMode.js.wasm-no-tls-context stress/v8-deltablue-strict.js.dfg-eager stress/proxy-with-unbalanced-getter-setter.js.no-cjit-collect-continuously microbenchmarks/delta-blue-try-catch.js.no-cjit-collect-continuously microbenchmarks/delta-blue-try-catch.js.dfg-eager-no-cjit-validate v8-v6/v8-deltablue.js.no-cjit-collect-continuously stress/dfg-put-accessors-by-id.js.ftl-eager-no-cjit wasm.yaml/wasm/js-api/extension-MemoryMode.js.default-wasm apiTests
Comment on attachment 350445 [details] Patch Attachment 350445 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/9305080 New failing tests: imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures_AES-CTR.https.any.worker.html imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures_ECDSA.https.any.worker.html webgl/1.0.2/conformance/uniforms/out-of-bounds-uniform-array-access.html
Created attachment 350465 [details] Archive of layout-test-results from ews102 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 350445 [details] Patch Attachment 350445 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9304971 New failing tests: imported/w3c/web-platform-tests/service-workers/service-worker/interfaces-sw.https.html
Created attachment 350466 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 350445 [details] Patch Attachment 350445 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9305648 New failing tests: imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures_HMAC.https.any.worker.html imported/w3c/web-platform-tests/service-workers/service-worker/interfaces-sw.https.html
Created attachment 350472 [details] Archive of layout-test-results from ews106 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 350445 [details] Patch Attachment 350445 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/9305405 New failing tests: imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/successes_AES-GCM.https.any.worker.html imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures_ECDH.https.any.worker.html
Created attachment 350473 [details] Archive of layout-test-results from ews117 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-sierra Platform: Mac OS X 10.12.6
Created attachment 350699 [details] Patch
Comment on attachment 350699 [details] Patch Attachment 350699 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/9339035 New failing tests: fast/workers/worker-exception-during-navigation.html
Created attachment 350737 [details] Archive of layout-test-results from ews203 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews203 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
The bytecode rewrite has landed in r237547 <https://trac.webkit.org/r237547>