Bug 189688 – Update flakiness dashboard configuration for iOS 12 queues

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Ryan Haddad]

Update flakiness dashboard configuration for iOS 12 queues

[Ryan Haddad]

Created attachment 350488 [details]
Patch

[Ryan Haddad]

CC'ing some Sony folks as an FYI since this incidentally adds WinCairo support to the flakiness dashboard.

[Ross Kirsling]

I think we might be missing some other pieces too though:
https://bugs.webkit.org/show_bug.cgi?id=188345
Fujii-san, is your patch on that ticket ready for review?

[Fujii Hironori]

I hesitate to land the patch because WinCairo Debug buildbos are broken all the time. But, I didn’t know the script generate_builders_json.py. I should add WinCairo Realse and Debug bots.

[Ryan Haddad]

(In reply to Fujii Hironori from comment #4)
> I hesitate to land the patch because WinCairo Debug buildbos are broken all
> the time. But, I didn’t know the script generate_builders_json.py. I should
> add WinCairo Realse and Debug bots.
I need to get iOS 12 support up ASAP, so I'm just going to edit my patch to remove WPE for now. You can add it with your change when you are ready.

[Ryan Haddad]

Created attachment 350644 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 350644 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350644&action=review

> Tools/TestResultServer/static-dashboards/builders.jsonp:26
> -                    "WPE Linux 64-bit Release (Tests)",
> -                    "WPE Linux 64-bit Debug (Tests)"
> +                    "WPE Linux 64-bit Debug (Tests)", 
> +                    "WPE Linux 64-bit Release (Tests)"

What does this change?

[Ryan Haddad]

(In reply to Ryan Haddad from comment #5)
> (In reply to Fujii Hironori from comment #4)
> > I hesitate to land the patch because WinCairo Debug buildbos are broken all
> > the time. But, I didn’t know the script generate_builders_json.py. I should
> > add WinCairo Realse and Debug bots.
> I need to get iOS 12 support up ASAP, so I'm just going to edit my patch to
> remove WPE for now. You can add it with your change when you are ready.

s/WPE/WinCairo

[Ryan Haddad]

(In reply to Alexey Proskuryakov from comment #7)
> Comment on attachment 350644 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=350644&action=review
> 
> > Tools/TestResultServer/static-dashboards/builders.jsonp:26
> > -                    "WPE Linux 64-bit Release (Tests)",
> > -                    "WPE Linux 64-bit Debug (Tests)"
> > +                    "WPE Linux 64-bit Debug (Tests)", 
> > +                    "WPE Linux 64-bit Release (Tests)"
> 
> What does this change?
The generate_builders_json.py script alphabetized these automatically when I ran it.

[Alexey Proskuryakov]

And added trailing whitespace, it seems!

[WebKit Commit Bot]

Comment on attachment 350644 [details]
Patch

Clearing flags on attachment: 350644

Committed r236406: <https://trac.webkit.org/changeset/236406>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/44730039>

[Aakash Jain]

Deployed on webkit-test-results, it's live now.