Bug 189683 - Bring up queues for iOS 12
Summary: Bring up queues for iOS 12
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryan Haddad
URL:
Keywords: InRadar
Depends on:
Blocks: 189688 189839
  Show dependency treegraph
 
Reported: 2018-09-17 16:17 PDT by Ryan Haddad
Modified: 2018-09-21 11:33 PDT (History)
10 users (show)

See Also:


Attachments
Patch (141.55 KB, patch)
2018-09-17 21:27 PDT, Ryan Haddad
no flags Details | Formatted Diff | Diff
Patch (141.48 KB, patch)
2018-09-17 22:06 PDT, Ryan Haddad
no flags Details | Formatted Diff | Diff
Patch (154.52 KB, patch)
2018-09-18 09:04 PDT, Ryan Haddad
no flags Details | Formatted Diff | Diff
Patch for landing (2.97 KB, patch)
2018-09-21 09:36 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff
Patch (1.39 KB, patch)
2018-09-21 10:23 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2018-09-17 16:17:41 PDT
Bring up queues for iOS 12
Comment 1 Ryan Haddad 2018-09-17 21:27:28 PDT
Created attachment 349997 [details]
Patch
Comment 2 Ryan Haddad 2018-09-17 22:06:58 PDT
Created attachment 350001 [details]
Patch
Comment 3 Alexey Proskuryakov 2018-09-17 23:56:02 PDT
We probably need flakiness dashboard changes as well. Also, IIRC there was a unit test for config.json in webkitpy (which should have been run by EWS, but wasn't).
Comment 4 Jonathan Bedard 2018-09-18 08:18:14 PDT
I wanted to call out the fact that Ryan changed the default iOS version in webkitpy in r233832, so that is not needed in this change.
Comment 5 Ryan Haddad 2018-09-18 09:04:52 PDT
Created attachment 350023 [details]
Patch
Comment 6 Ryan Haddad 2018-09-18 09:06:08 PDT
(In reply to Alexey Proskuryakov from comment #3)
> We probably need flakiness dashboard changes as well. Also, IIRC there was a
> unit test for config.json in webkitpy (which should have been run by EWS,
> but wasn't).

https://bugs.webkit.org/show_bug.cgi?id=189688 tracks the flakiness dashboard changes. The script that generates the config requires the builders to be in place first.

Thanks for the reminder about the unit tests. New patch addresses these.
Comment 7 WebKit Commit Bot 2018-09-20 16:50:17 PDT
Comment on attachment 350023 [details]
Patch

Clearing flags on attachment: 350023

Committed r236294: <https://trac.webkit.org/changeset/236294>
Comment 8 WebKit Commit Bot 2018-09-20 16:50:18 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2018-09-20 16:51:40 PDT
<rdar://problem/44661252>
Comment 10 Jonathan Bedard 2018-09-21 09:36:51 PDT
Reopening to attach new patch.
Comment 11 Jonathan Bedard 2018-09-21 09:36:52 PDT
Created attachment 350373 [details]
Patch for landing
Comment 12 WebKit Commit Bot 2018-09-21 10:13:44 PDT
Comment on attachment 350373 [details]
Patch for landing

Clearing flags on attachment: 350373

Committed r236331: <https://trac.webkit.org/changeset/236331>
Comment 13 WebKit Commit Bot 2018-09-21 10:13:46 PDT
All reviewed patches have been landed.  Closing bug.
Comment 14 Jonathan Bedard 2018-09-21 10:23:04 PDT
Reopening to attach new patch.
Comment 15 Jonathan Bedard 2018-09-21 10:23:05 PDT
Created attachment 350376 [details]
Patch
Comment 16 Jonathan Bedard 2018-09-21 10:24:14 PDT
(In reply to Jonathan Bedard from comment #15)
> Created attachment 350376 [details]
> Patch

Running this through EWS to make sure it doesn't break anything else, verified that this fixes iOS 12 device and simulator builds.
Comment 17 Jonathan Bedard 2018-09-21 11:07:31 PDT
Comment on attachment 350376 [details]
Patch

Builds for iOS and Mac passed, those were what might have been broken by this change. Landing to fix our iOS 12 builders.
Comment 18 WebKit Commit Bot 2018-09-21 11:33:27 PDT
Comment on attachment 350376 [details]
Patch

Clearing flags on attachment: 350376

Committed r236337: <https://trac.webkit.org/changeset/236337>
Comment 19 WebKit Commit Bot 2018-09-21 11:33:28 PDT
All reviewed patches have been landed.  Closing bug.