Bring up queues for iOS 12
Created attachment 349997 [details] Patch
Created attachment 350001 [details] Patch
We probably need flakiness dashboard changes as well. Also, IIRC there was a unit test for config.json in webkitpy (which should have been run by EWS, but wasn't).
I wanted to call out the fact that Ryan changed the default iOS version in webkitpy in r233832, so that is not needed in this change.
Created attachment 350023 [details] Patch
(In reply to Alexey Proskuryakov from comment #3) > We probably need flakiness dashboard changes as well. Also, IIRC there was a > unit test for config.json in webkitpy (which should have been run by EWS, > but wasn't). https://bugs.webkit.org/show_bug.cgi?id=189688 tracks the flakiness dashboard changes. The script that generates the config requires the builders to be in place first. Thanks for the reminder about the unit tests. New patch addresses these.
Comment on attachment 350023 [details] Patch Clearing flags on attachment: 350023 Committed r236294: <https://trac.webkit.org/changeset/236294>
All reviewed patches have been landed. Closing bug.
<rdar://problem/44661252>
Reopening to attach new patch.
Created attachment 350373 [details] Patch for landing
Comment on attachment 350373 [details] Patch for landing Clearing flags on attachment: 350373 Committed r236331: <https://trac.webkit.org/changeset/236331>
Created attachment 350376 [details] Patch
(In reply to Jonathan Bedard from comment #15) > Created attachment 350376 [details] > Patch Running this through EWS to make sure it doesn't break anything else, verified that this fixes iOS 12 device and simulator builds.
Comment on attachment 350376 [details] Patch Builds for iOS and Mac passed, those were what might have been broken by this change. Landing to fix our iOS 12 builders.
Comment on attachment 350376 [details] Patch Clearing flags on attachment: 350376 Committed r236337: <https://trac.webkit.org/changeset/236337>