Bug 189535 – [WHLSL] The standard library should be fully tested

• Status: RESOLVED
• Resolution: MOVED
• Component: New Bugs

[Thomas Denney]

[WHLSL] The standard library should be fully tested

[Thomas Denney]

Created attachment 349500 [details]
WIP

[Thomas Denney]

We cannot remove the preparation stage that type checks the standard library in full (which makes running tests *much* faster) without ensuring that every function in the standard library is tested to ensure that each standard library function actually gets type checked.

[Myles C. Maxfield]

There are a couple functions that I'm not very confident that their behavior matches HLSL:

firstbithigh()
firstbitlow()
countbits()
reversebits()
all the texturing functions

Also, these functions are implemented in a suboptimal way:

log2()
log10()
exp2()
fmod()
isordered()

Also: fma() and mad() are implemented identically, and I'm not sure if this is right.

[Thomas Denney]

(In reply to Myles C. Maxfield from comment #3)
> There are a couple functions that I'm not very confident that their behavior
> matches HLSL:
> 
> firstbithigh()
> firstbitlow()
> countbits()
> reversebits()
> all the texturing functions
> 
> Also, these functions are implemented in a suboptimal way:
> 
> log2()
> log10()
> exp2()
> fmod()
> isordered()
> 
> Also: fma() and mad() are implemented identically, and I'm not sure if this
> is right.

Likewise I’m pretty sure that isnormal isn’t implement correctly (it currently returns isNaN).

[Myles C. Maxfield]

Migrated to https://api.github.com/repos/gpuweb/WHLSL/issues/36

[Myles C. Maxfield]

https://github.com/gpuweb/WHLSL/issues/36