Bug 189475 – [iOS] Unable to change the value of select elements while preserving focus state

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Wenson Hsieh]

<rdar://problem/41125764>

[Wenson Hsieh]

Created attachment 349332 [details]
Patch

[Tim Horton]

Comment on attachment 349332 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349332&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:458
> +    // However, unlike active focus state, it may be safely reset to 0.

Probably need to define "safely" here. "Without impact to existing API contracts?"

[Wenson Hsieh]

Comment on attachment 349332 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349332&action=review

>> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:458
>> +    // However, unlike active focus state, it may be safely reset to 0.
> 
> Probably need to define "safely" here. "Without impact to existing API contracts?"

That's right — it's part "without impact to existing behavior of -_retainActiveFocusedState", and also part "able to be reset to 0 at any time" (with future calls to decrement the counter being noops). I'll clarify this in the comment.

[Wenson Hsieh]

Created attachment 349354 [details]
Patch for landing

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 349354 [details]:

The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 349354 [details]:

imported/w3c/web-platform-tests/xhr/access-control-and-redirects.htm bug 189489 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 349354 [details]
Patch for landing

Clearing flags on attachment: 349354

Committed r235878: <https://trac.webkit.org/changeset/235878>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.