Bug 189360 – [WHLSL] Call arguments should be copied as soon as they are evaluated

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGPU

[Thomas Denney]

There is an observable bug in the interpreter whereby the shallow copy of values only occurred after all arguments to a call had been evaluated.

[Thomas Denney]

Created attachment 349045 [details]
Patch

[Myles C. Maxfield]

Comment on attachment 349045 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349045&action=review

> Tools/WebGPUShadingLanguageRI/Evaluator.js:325
> +        let result = EBuffer.allowAllocation(() => node.func.implementation(callArguments, node));

I'm confused. Where do the thunks get evaluated? I expected this patch to move code around, but instead it appears to be deleting code?

[Myles C. Maxfield]

Comment on attachment 349045 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349045&action=review

>> Tools/WebGPUShadingLanguageRI/Evaluator.js:325
>> +        let result = EBuffer.allowAllocation(() => node.func.implementation(callArguments, node));
> 
> I'm confused. Where do the thunks get evaluated? I expected this patch to move code around, but instead it appears to be deleting code?

Got it. Looks good.

[WebKit Commit Bot]

Comment on attachment 349045 [details]
Patch

Clearing flags on attachment: 349045

Committed r235753: <https://trac.webkit.org/changeset/235753>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/44194725>

[Myles C. Maxfield]

Migrated to https://github.com/gpuweb/WHLSL/issues/41