Bug 189344 - [GTK] webanimations/css-animation-effect-target-change-and-animation-removal-crash.html failing since added in r234848 "[Web Animations] Crash under AnimationTimeline::cancelOrRemoveDeclarativeAnimation()"
Summary: [GTK] webanimations/css-animation-effect-target-change-and-animation-removal-...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Claudio Saavedra
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-06 07:07 PDT by Miguel Gomez
Modified: 2019-03-18 06:43 PDT (History)
4 users (show)

See Also:


Attachments
Patch (2.25 KB, patch)
2019-03-18 06:18 PDT, Claudio Saavedra
pnormand: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Miguel Gomez 2018-09-06 07:07:31 PDT
webanimations/css-animation-effect-target-change-and-animation-removal-crash.html [ ImageOnlyFailure ]

I'm not sure this is a fail of the test or a fail in the way we compare the test results. This reftest seems to compare a page that's expected to cause a crash with an empty page, and fails in the comparison, maybe because we don't support an empty page. Seems that the bot is not able to generate the result or the diff images.
Comment 1 Claudio Saavedra 2019-03-18 06:13:01 PDT
This is pretty much the same as in https://bugs.webkit.org/show_bug.cgi?id=171058 . Replacing the empty file with a 1 byte file makes the test pass.
Comment 2 Claudio Saavedra 2019-03-18 06:18:28 PDT
Created attachment 365012 [details]
Patch
Comment 3 Claudio Saavedra 2019-03-18 06:43:07 PDT
Committed r243061: <https://trac.webkit.org/changeset/243061>