WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
189315
[macOS] DragAndDropTests.ExposeMultipleURLsInDataTransfer fails on macOS versions prior to Mojave
https://bugs.webkit.org/show_bug.cgi?id=189315
Summary
[macOS] DragAndDropTests.ExposeMultipleURLsInDataTransfer fails on macOS vers...
Wenson Hsieh
Reported
2018-09-05 13:34:23 PDT
[macOS] DragAndDropTests.ExposeMultipleURLsInDataTransfer fails on macOS versions prior to Mojave
Attachments
Patch
(1.70 KB, patch)
2018-09-05 13:35 PDT
,
Wenson Hsieh
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Wenson Hsieh
Comment 1
2018-09-05 13:35:08 PDT
Created
attachment 348958
[details]
Patch
WebKit Commit Bot
Comment 2
2018-09-05 14:16:02 PDT
Comment on
attachment 348958
[details]
Patch Clearing flags on attachment: 348958 Committed
r235689
: <
https://trac.webkit.org/changeset/235689
>
WebKit Commit Bot
Comment 3
2018-09-05 14:16:03 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4
2018-09-05 14:17:59 PDT
<
rdar://problem/44153801
>
Darin Adler
Comment 5
2018-09-08 18:34:35 PDT
Comment on
attachment 348958
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=348958&action=review
> Tools/TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:51 > + WKPreferencesSetCustomPasteboardDataEnabled((WKPreferencesRef)[webView configuration].preferences, true);
__bridge WKPreferencesRef
Darin Adler
Comment 6
2018-09-08 18:35:10 PDT
Sorry, I mean that as a question.
Wenson Hsieh
Comment 7
2018-09-08 18:51:09 PDT
(In reply to Darin Adler from
comment #6
)
> Sorry, I mean that as a question.
You're right, it looks like this should be bridged (WKPreferencesRef <=> WKPreferences). I'll fix instances of this in TestWebKitAPI here: <
https://bugs.webkit.org/show_bug.cgi?id=189457
>.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug