Bug 189315 - [macOS] DragAndDropTests.ExposeMultipleURLsInDataTransfer fails on macOS versions prior to Mojave
Summary: [macOS] DragAndDropTests.ExposeMultipleURLsInDataTransfer fails on macOS vers...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-09-05 13:34 PDT by Wenson Hsieh
Modified: 2018-09-08 18:51 PDT (History)
9 users (show)

See Also:

Attachments
Patch (1.70 KB, patch)
2018-09-05 13:35 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2018-09-05 13:34:23 PDT 
[macOS] DragAndDropTests.ExposeMultipleURLsInDataTransfer fails on macOS versions prior to Mojave
Comment 1 Wenson Hsieh 2018-09-05 13:35:08 PDT 
Created attachment 348958 [details]
Patch
Comment 2 WebKit Commit Bot 2018-09-05 14:16:02 PDT 
Comment on attachment 348958 [details]
Patch

Clearing flags on attachment: 348958

Committed r235689: <https://trac.webkit.org/changeset/235689>
Comment 3 WebKit Commit Bot 2018-09-05 14:16:03 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2018-09-05 14:17:59 PDT 
<rdar://problem/44153801>
Comment 5 Darin Adler 2018-09-08 18:34:35 PDT 
Comment on attachment 348958 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348958&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:51
> +    WKPreferencesSetCustomPasteboardDataEnabled((WKPreferencesRef)[webView configuration].preferences, true);

__bridge WKPreferencesRef
Comment 6 Darin Adler 2018-09-08 18:35:10 PDT 
Sorry, I mean that as a question.
Comment 7 Wenson Hsieh 2018-09-08 18:51:09 PDT 
(In reply to Darin Adler from comment #6)
> Sorry, I mean that as a question.

You're right, it looks like this should be bridged (WKPreferencesRef <=> WKPreferences). I'll fix instances of this in TestWebKitAPI here: <https://bugs.webkit.org/show_bug.cgi?id=189457>.