Bug 189457 - [Cocoa] Use more bridging casts in TestWebKitAPI
Summary: [Cocoa] Use more bridging casts in TestWebKitAPI
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-09-08 18:50 PDT by Wenson Hsieh
Modified: 2018-09-08 21:25 PDT (History)
4 users (show)

See Also:


Attachments
Patch (61.32 KB, patch)
2018-09-08 20:26 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2018-09-08 18:50:03 PDT
SSIA
Comment 1 Wenson Hsieh 2018-09-08 20:26:18 PDT
Created attachment 349275 [details]
Patch
Comment 2 Darin Adler 2018-09-08 20:42:26 PDT
Comment on attachment 349275 [details]
Patch

Thanks. These look good. I am working on a patch that turns on ARC for TestWebKitAPI and this should have a good overlap with the changes needed for that. Under ARC these get checked a little bit more so it might catch some mistakes that are harmless in non-ARC.
Comment 3 WebKit Commit Bot 2018-09-08 21:24:39 PDT
Comment on attachment 349275 [details]
Patch

Clearing flags on attachment: 349275

Committed r235835: <https://trac.webkit.org/changeset/235835>
Comment 4 WebKit Commit Bot 2018-09-08 21:24:41 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-09-08 21:25:17 PDT
<rdar://problem/44269797>