RESOLVED FIXED 189457
[Cocoa] Use more bridging casts in TestWebKitAPI 
https://bugs.webkit.org/show_bug.cgi?id=189457
Summary [Cocoa] Use more bridging casts in TestWebKitAPI
Wenson Hsieh
Reported 2018-09-08 18:50:03 PDT
SSIA
Attachments
Patch (61.32 KB, patch)
2018-09-08 20:26 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2018-09-08 20:26:18 PDT
Created attachment 349275 [details] Patch
Darin Adler
Comment 2 2018-09-08 20:42:26 PDT
Comment on attachment 349275 [details] Patch Thanks. These look good. I am working on a patch that turns on ARC for TestWebKitAPI and this should have a good overlap with the changes needed for that. Under ARC these get checked a little bit more so it might catch some mistakes that are harmless in non-ARC.
WebKit Commit Bot
Comment 3 2018-09-08 21:24:39 PDT
Comment on attachment 349275 [details] Patch Clearing flags on attachment: 349275 Committed r235835: <https://trac.webkit.org/changeset/235835>
WebKit Commit Bot
Comment 4 2018-09-08 21:24:41 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2018-09-08 21:25:17 PDT
<rdar://problem/44269797>
Note You need to log in before you can comment on or make changes to this bug.