Bug 189108 - [WHSL] Need grammar to specify kernel group size
Summary: [WHSL] Need grammar to specify kernel group size
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
: 189384 (view as bug list)
Depends on:
Blocks: 176199 189202
  Show dependency treegraph
 
Reported: 2018-08-29 16:12 PDT by Myles C. Maxfield
Modified: 2018-10-13 14:58 PDT (History)
3 users (show)

See Also:


Attachments
Patch (21.89 KB, patch)
2018-09-22 15:17 PDT, Myles C. Maxfield
dino: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2018-08-29 16:12:06 PDT
https://github.com/Microsoft/DirectX-Graphics-Samples/blob/8f68bf07dfd134df3b90e83a63535d053bae9a8a/Libraries/D3D12RaytracingFallback/src/FallbackLayerUnitTests/DynamicIndexTest.hlsl

Compute shader entry points need to have something like the following before their declaration:
[numthreads( 8, 8, 1 )]
Comment 2 Radar WebKit Bug Importer 2018-09-12 18:51:02 PDT
<rdar://problem/44403004>
Comment 3 Myles C. Maxfield 2018-09-22 14:05:55 PDT
*** Bug 189384 has been marked as a duplicate of this bug. ***
Comment 4 Myles C. Maxfield 2018-09-22 15:17:26 PDT
Created attachment 350534 [details]
Patch
Comment 5 Myles C. Maxfield 2018-09-22 16:49:42 PDT
Committed r236390: <https://trac.webkit.org/changeset/236390>
Comment 6 Myles C. Maxfield 2018-10-13 14:58:53 PDT
Migrated to https://github.com/gpuweb/WHLSL/issues/66