Bug 189083 – [WHLSL] Ensure that isLValue is copied by the rewriter

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGPU

[Thomas Denney]

[WHLSL] Ensure that isLValue is copied by the rewriter

[Thomas Denney]

Created attachment 348403 [details]
Patch

[Thomas Denney]

Created attachment 348405 [details]
Patch

[Myles C. Maxfield]

Comment on attachment 348405 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348405&action=review

> Tools/WebGPUShadingLanguageRI/Test.js:275
> +    function ternaryExpressionIsLValue(node)
> +    {
> +        let isLValue;
> +        class TernaryExpressionVisitor extends Visitor {
> +            visitTernaryExpression(node)
> +            {
> +                isLValue = node.isLValue;
> +            }
> +        }
> +        node.visit(new TernaryExpressionVisitor());
> +        return isLValue;
> +    }

This is an unfortunate test, because it doesn't describe anything user-visible. Are you sure there's no way this bug is visible without using compiler internals?

[Thomas Denney]

Comment on attachment 348405 [details]
Patch

The last place that isLValue gets read in the interpreter is inside Checker, however after that has completed the entire program is rewritten using Inliner, which is a subclass of Rewriter.

[WebKit Commit Bot]

Comment on attachment 348405 [details]
Patch

Clearing flags on attachment: 348405

Committed r235470: <https://trac.webkit.org/changeset/235470>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/43850362>

[Myles C. Maxfield]

Migrated to https://github.com/gpuweb/WHLSL/issues/73