Bug 189014 - [WHLSL] The parser is too slow
Summary: [WHLSL] The parser is too slow
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks: 176199 189202
  Show dependency tree / graph
 
Reported: 2018-08-27 15:18 PDT by Myles C. Maxfield
Modified: 2018-10-13 15:20 PDT (History)
7 users (show)

See Also:

Attachments
WIP (32.18 KB, patch)
2018-09-04 19:41 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
first draft (60.82 KB, patch)
2018-09-05 11:42 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Second draft (51.31 KB, patch)
2018-09-05 13:06 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Removes try/catch (54.33 KB, patch)
2018-09-05 15:12 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (62.09 KB, patch)
2018-09-05 17:27 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (63.37 KB, patch)
2018-09-05 19:00 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (63.37 KB, patch)
2018-09-05 19:10 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2018-08-27 15:18:46 PDT 
It takes 2.5 hours to compile the standard library. 95% of the time is spent parsing.
Comment 1 Myles C. Maxfield 2018-08-27 15:21:28 PDT 

*** This bug has been marked as a duplicate of bug 188517 ***
Comment 2 Myles C. Maxfield 2018-08-28 15:54:30 PDT 
Reopening
Comment 3 Myles C. Maxfield 2018-09-04 19:41:52 PDT 
Created attachment 348887 [details]
WIP
Comment 4 Myles C. Maxfield 2018-09-05 11:42:55 PDT 
Created attachment 348951 [details]
first draft
Comment 5 Myles C. Maxfield 2018-09-05 13:06:32 PDT 
Created attachment 348955 [details]
Second draft
Comment 6 Myles C. Maxfield 2018-09-05 15:12:22 PDT 
Created attachment 348970 [details]
Removes try/catch
Comment 7 Myles C. Maxfield 2018-09-05 17:27:41 PDT 
Created attachment 348985 [details]
Patch
Comment 8 Thomas Denney 2018-09-05 17:34:54 PDT 
Comment on attachment 348985 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348985&action=review

> Tools/WebGPUShadingLanguageRI/Lexer.js:45
> +        }

Weird characters here.
Comment 9 Myles C. Maxfield 2018-09-05 19:00:45 PDT 
Created attachment 348993 [details]
Patch
Comment 10 Myles C. Maxfield 2018-09-05 19:10:37 PDT 
Created attachment 348994 [details]
Patch
Comment 11 WebKit Commit Bot 2018-09-06 09:01:13 PDT 
Comment on attachment 348994 [details]
Patch

Clearing flags on attachment: 348994

Committed r235738: <https://trac.webkit.org/changeset/235738>
Comment 12 WebKit Commit Bot 2018-09-06 09:01:14 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 13 Radar WebKit Bug Importer 2018-09-06 09:03:27 PDT 
<rdar://problem/44183440>
Comment 14 Myles C. Maxfield 2018-10-13 15:20:47 PDT 
Migrated to https://github.com/gpuweb/WHLSL/issues/87