Created attachment 348079 [details] Screenshot of the problem in action How to reproduce: Run the following code: console.log("video:1:2"); console.log("video/mp4:1:2"); console.log("video/mp4 : 00:04:42-00:04:44"); Expected output: video:1:2 video/mp4:1:2 video/mp4 : 00:04:42-00:04:44 Actual output: [f] video:1:2 [N] (anonymous function) [N] (anonymous function) What's going on? The issue also reproduces when evaluating strings directly in the console, but not when they are enclosed in an array.
This seems like a heuristic gone bad! I think this is the "attempt to detect a callstack" code. That should probably only work if it seems multiple potential frames, not one.
(In reply to Joseph Pecoraro from comment #1) > This seems like a heuristic gone bad! I think this is the "attempt to detect > a callstack" code. That should probably only work if it seems multiple > potential frames, not one. Does it think it's a Error.stack and is trying to be helpful? How does that work, given that JSC `Error.stack` does not include line numbers nor a very distinct syntax?
<rdar://problem/43756428>
Created attachment 348271 [details] Patch
Created attachment 348272 [details] Patch Just saw Joe's comment. Added another condition relating to the number of lines/frames.
Comment on attachment 348272 [details] Patch Attachment 348272 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/9007856 New failing tests: inspector/console/js-isLikelyStackTrace.html
Created attachment 348278 [details] Archive of layout-test-results from ews103 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 348272 [details] Patch Attachment 348272 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/9007990 New failing tests: inspector/console/js-isLikelyStackTrace.html
Created attachment 348282 [details] Archive of layout-test-results from ews114 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 348272 [details] Patch Attachment 348272 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9008089 New failing tests: inspector/console/js-isLikelyStackTrace.html
Created attachment 348283 [details] Archive of layout-test-results from ews106 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Created attachment 348303 [details] Patch
Comment on attachment 348303 [details] Patch Attachment 348303 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9012560 New failing tests: css3/filters/backdrop/add-remove-add-backdrop-filter.html
Created attachment 348316 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 348303 [details] Patch Code change seems fine, but you need to add new coverage to LayoutTests/inspector/console/js-isLikelyStackTrace.html
Created attachment 348356 [details] Patch
Comment on attachment 348356 [details] Patch r=me (wait for EWS)
Comment on attachment 348356 [details] Patch Clearing flags on attachment: 348356 Committed r235452: <https://trac.webkit.org/changeset/235452>
All reviewed patches have been landed. Closing bug.
*** Bug 189750 has been marked as a duplicate of this bug. ***