Bug 188940 - [WHLSL] Implement texture types
Summary: [WHLSL] Implement texture types
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks: 176199 189202 189225 189226
  Show dependency treegraph
 
Reported: 2018-08-24 19:19 PDT by Myles C. Maxfield
Modified: 2018-10-13 19:13 PDT (History)
2 users (show)

See Also:


Attachments
WIP (197.83 KB, patch)
2018-08-24 19:20 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
WIP (196.22 KB, patch)
2018-08-28 15:06 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
WIP (203.86 KB, patch)
2018-08-28 17:31 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
WIP (238.46 KB, patch)
2018-08-28 19:24 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
WIP (54.24 KB, patch)
2018-08-29 14:19 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
WIP (54.62 KB, patch)
2018-08-29 18:23 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
WIP (66.84 KB, patch)
2018-08-29 19:13 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
WIP (66.99 KB, patch)
2018-08-29 19:18 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
WIP (79.99 KB, patch)
2018-08-30 11:54 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
WIP (86.58 KB, patch)
2018-08-30 19:24 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
WIP (86.65 KB, patch)
2018-08-30 19:25 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
WIP (89.16 KB, patch)
2018-08-30 23:04 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
WIP (108.18 KB, patch)
2018-08-31 12:08 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
WIP (163.98 KB, patch)
2018-08-31 17:22 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Can sample (165.51 KB, patch)
2018-08-31 18:25 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Can sample (167.05 KB, patch)
2018-08-31 19:42 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
WIP (170.72 KB, patch)
2018-08-31 22:02 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
WIP (183.19 KB, patch)
2018-09-01 14:03 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
WIP (192.66 KB, patch)
2018-09-01 15:18 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
WIP (219.11 KB, patch)
2018-09-01 18:13 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
WIP (255.38 KB, patch)
2018-09-01 19:36 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
WIP (396.04 KB, patch)
2018-09-01 22:28 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
WIP (401.56 KB, patch)
2018-09-01 22:40 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
WIP (428.97 KB, patch)
2018-09-02 17:03 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
WIP (414.79 KB, patch)
2018-09-02 22:58 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Cubemaps complete (426.25 KB, patch)
2018-09-03 09:20 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Started gathering (434.52 KB, patch)
2018-09-03 15:23 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Test gathering (456.47 KB, patch)
2018-09-03 17:06 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Patch (458.01 KB, patch)
2018-09-03 17:33 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Needs finishing touches (458.00 KB, patch)
2018-09-03 19:51 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Needs tests for SampleCmpLevelZero (459.30 KB, patch)
2018-09-03 19:56 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Patch (488.01 KB, patch)
2018-09-03 21:39 PDT, Myles C. Maxfield
dino: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2018-08-24 19:19:59 PDT
[WHLSL] Implement texture types
Comment 1 Myles C. Maxfield 2018-08-24 19:20:21 PDT
Created attachment 348066 [details]
WIP
Comment 2 Myles C. Maxfield 2018-08-27 16:26:14 PDT
We should make sure we test things like Texture2D<vector<float, 4>>
Comment 3 Myles C. Maxfield 2018-08-28 15:06:23 PDT
Created attachment 348347 [details]
WIP
Comment 4 Myles C. Maxfield 2018-08-28 17:31:44 PDT
Created attachment 348365 [details]
WIP
Comment 5 Myles C. Maxfield 2018-08-28 19:24:58 PDT
Created attachment 348376 [details]
WIP
Comment 6 Myles C. Maxfield 2018-08-29 14:19:32 PDT
Created attachment 348433 [details]
WIP
Comment 7 Myles C. Maxfield 2018-08-29 18:23:38 PDT
Created attachment 348459 [details]
WIP
Comment 8 Myles C. Maxfield 2018-08-29 19:13:06 PDT
Created attachment 348464 [details]
WIP
Comment 9 Myles C. Maxfield 2018-08-29 19:18:44 PDT
Created attachment 348467 [details]
WIP
Comment 10 Myles C. Maxfield 2018-08-30 11:54:23 PDT
Created attachment 348521 [details]
WIP
Comment 11 Myles C. Maxfield 2018-08-30 19:24:02 PDT
Created attachment 348581 [details]
WIP
Comment 12 Myles C. Maxfield 2018-08-30 19:25:35 PDT
Created attachment 348582 [details]
WIP
Comment 13 Myles C. Maxfield 2018-08-30 23:04:20 PDT
Created attachment 348607 [details]
WIP
Comment 14 Myles C. Maxfield 2018-08-31 12:08:27 PDT
Created attachment 348661 [details]
WIP
Comment 15 Myles C. Maxfield 2018-08-31 17:22:11 PDT
Created attachment 348687 [details]
WIP
Comment 16 Myles C. Maxfield 2018-08-31 18:25:38 PDT
Created attachment 348695 [details]
Can sample
Comment 17 Myles C. Maxfield 2018-08-31 19:42:10 PDT
Created attachment 348698 [details]
Can sample
Comment 18 Myles C. Maxfield 2018-08-31 22:02:49 PDT
Created attachment 348705 [details]
WIP
Comment 19 Myles C. Maxfield 2018-09-01 14:03:27 PDT
Created attachment 348717 [details]
WIP
Comment 20 Myles C. Maxfield 2018-09-01 15:18:48 PDT
Created attachment 348718 [details]
WIP
Comment 21 Myles C. Maxfield 2018-09-01 18:13:32 PDT
Created attachment 348723 [details]
WIP
Comment 22 Myles C. Maxfield 2018-09-01 19:36:01 PDT
Created attachment 348724 [details]
WIP
Comment 23 Myles C. Maxfield 2018-09-01 22:28:48 PDT
Created attachment 348726 [details]
WIP
Comment 24 Myles C. Maxfield 2018-09-01 22:40:39 PDT
Created attachment 348727 [details]
WIP
Comment 25 Myles C. Maxfield 2018-09-02 17:03:34 PDT
Created attachment 348752 [details]
WIP
Comment 26 Myles C. Maxfield 2018-09-02 22:58:10 PDT
Created attachment 348758 [details]
WIP
Comment 27 Myles C. Maxfield 2018-09-03 09:20:22 PDT
Created attachment 348775 [details]
Cubemaps complete
Comment 28 Myles C. Maxfield 2018-09-03 15:23:56 PDT
Created attachment 348791 [details]
Started gathering
Comment 29 Myles C. Maxfield 2018-09-03 17:06:15 PDT
Created attachment 348797 [details]
Test gathering
Comment 30 Myles C. Maxfield 2018-09-03 17:33:39 PDT
Created attachment 348798 [details]
Patch
Comment 31 Myles C. Maxfield 2018-09-03 19:51:49 PDT
Created attachment 348800 [details]
Needs finishing touches
Comment 32 Myles C. Maxfield 2018-09-03 19:56:42 PDT
Created attachment 348801 [details]
Needs tests for SampleCmpLevelZero
Comment 33 Myles C. Maxfield 2018-09-03 21:39:02 PDT
Created attachment 348804 [details]
Patch
Comment 34 Dean Jackson 2018-09-04 11:31:25 PDT
Comment on attachment 348804 [details]
Patch

rs=me
Comment 35 Myles C. Maxfield 2018-09-04 14:18:30 PDT
Committed r235635: <https://trac.webkit.org/changeset/235635>
Comment 36 Radar WebKit Bug Importer 2018-09-04 14:19:20 PDT
<rdar://problem/44112106>
Comment 37 Myles C. Maxfield 2018-09-04 14:42:07 PDT
Committed r235642: <https://trac.webkit.org/changeset/235642>
Comment 38 Myles C. Maxfield 2018-10-13 19:13:46 PDT
Migrated to https://github.com/gpuweb/WHLSL/issues/89